Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[Fix] parameter_types! dead code errors #12340

Merged
merged 2 commits into from
Sep 23, 2022
Merged

[Fix] parameter_types! dead code errors #12340

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b97f84
[Fix] parameter_types! dead code errors
ruseinov Sep 23, 2022
92ccc92
mark the whole impl allow(unused)
ruseinov Sep 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions frame/support/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,9 +361,9 @@ macro_rules! parameter_types {
}
};
(IMPL_STORAGE $name:ident, $type:ty, $value:expr $(, $ty_params:ident)*) => {
#[allow(unused)]
impl< $($ty_params),* > $name< $($ty_params),* > {
/// Returns the key for this parameter type.
#[allow(unused)]
pub fn key() -> [u8; 16] {
$crate::sp_core_hashing_proc_macro::twox_128!(b":", $name, b":")
}
Expand All @@ -372,7 +372,6 @@ macro_rules! parameter_types {
///
/// This needs to be executed in an externalities provided
/// environment.
#[allow(unused)]
pub fn set(value: &$type) {
$crate::storage::unhashed::put(&Self::key(), value);
}
Expand Down Expand Up @@ -448,6 +447,7 @@ macro_rules! parameter_types_impl_thread_local {
}

/// Mutate the internal value in place.
#[allow(unused)]
Copy link
Member

@ggwpez ggwpez Sep 23, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we mark the whole impl as allow(unused)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe more fine grained control over this is better, that way nothing ever gets lost. What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

pub fn mutate<R, F: FnOnce(&mut $type) -> R>(mutate: F) -> R{
let mut current = Self::get();
let result = mutate(&mut current);
Expand All @@ -456,6 +456,7 @@ macro_rules! parameter_types_impl_thread_local {
}

/// Get current value and replace with initial value of the parameter type.
#[allow(unused)]
pub fn take() -> $type {
let current = Self::get();
Self::set($value);
Expand Down