This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Remove "to_block" field from BlockRequests #12447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
added
A0-please_review
arkpar
approved these changes
Oct 7, 2022
bkchr
approved these changes
Oct 8, 2022
|
bot merge |
|
Error: Statuses failed for 8c6ae67 |
|
bot merge |
|
Waiting for commit status. |
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Remove "to_block" field from BlockRequests * Maybe fix the tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the receiving side, this field is completely ignored when we receive a request.
On the sender side, we always set this field to
None, with the sole exception of warp syncing where we set it to the same value as the starting block because we want one specific block.As far as I know, not only this field isn't used right now but has never been used.
Since this field is useless, this PR removes it.
Because we're using protobuf, it's not a problem if a client on an old version sends us a warp sync request where the field is defined. The now-unrecognized field will simply be ignored.
If this is approved, a corresponding issue should be opened in the w3f/specs repo.