This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
root_testing
pallet #12451New
root_testing
pallet #12451Changes from 22 commits
aae3ad4
fae1f2f
450b02f
dd5be15
31957e7
85de51f
796b021
6dc4371
10654bc
afb0518
b8e7c21
346070b
f7ca099
95d734b
76c01ec
97cd12c
667b5da
5c46eff
6356478
3ad36d1
6e37379
0780410
a52b05e
9099a55
62e4f83
370f46e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this breaks transaction version.
can we have a dummy call to preserve the call index of the other calls to reduce the impact?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would that call look like? Or could there be a more elegant solution to this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recall there were some discussion about specify call index to avoid this kind of issue but can't find it anymore. That will be the proper solution.
For now, maybe just
pub fn removed_call_do_not_use(origin: OriginFor<T>, _ratio: Perbill)
and make the weight to be block weight so it cannot be includedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xlc do we even need
_ratio
as an argument?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need the argument.
@xlc is this a big deal though? most apps should handle this dynamically. For others, in any case, almost all releases contain a tx-version breaking change (bth we are not even bumping it strictly).
I would say let's break it and move on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kianenigma I removed the dummy call then.