This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Execute try-state at end of each test to ensure pallet data integrity #12453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
A3-in_progress
Ank4n
changed the title
kianenigma
reviewed
Oct 10, 2022
frame/staking/src/mock.rs
Outdated
| let diff = nominator_stake - sum; | ||
| assert!(diff < 100); | ||
| ext.execute_with(|| { | ||
| let try_state = Staking::do_try_state(0); |
There was a problem hiding this comment.
Suggested change
| let try_state = Staking::do_try_state(0); | |
| let try_state = Staking::do_try_state(System::block_number()); |
kianenigma
approved these changes
Oct 10, 2022
github-actions
bot
added
A0-please_review
Ank4n
changed the title
Ank4n
added
B0-silent
|
bot rebase |
|
Rebased |
|
Removes a lot of test code? |
Nope. The |
gavofyork
approved these changes
Oct 17, 2022
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
…paritytech#12453) * execute try-state at end of tests * run post condition only with try runtime * Revert "run post condition only with try runtime" This reverts commit 7db0ecf. * voterlist contains validators as well * fmt * simplify * fmt Co-authored-by: parity-processbot <>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12199