Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Prepare for latest clippy (nightly 09-10-2022) #12466

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Prepare for latest clippy (nightly 09-10-2022) #12466

merged 1 commit into from
Oct 18, 2022

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Oct 10, 2022

No description provided.

@bkchr bkchr added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Oct 10, 2022
@bkchr bkchr requested a review from ggwpez October 10, 2022 21:03
ggwpez
ggwpez approved these changes Oct 11, 2022
View reviewed changes
primitives/runtime/src/offchain/storage_lock.rs
const STORAGE_LOCK_PER_CHECK_ITERATION_SNOOZE_MIN: Duration = Duration::from_millis(100);
const STORAGE_LOCK_PER_CHECK_ITERATION_SNOOZE_MAX: Duration = Duration::from_millis(10);
const STORAGE_LOCK_PER_CHECK_ITERATION_SNOOZE_MIN: Duration = Duration::from_millis(10);
const STORAGE_LOCK_PER_CHECK_ITERATION_SNOOZE_MAX: Duration = Duration::from_millis(100);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it was actually bogus?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@andresilva
Copy link
Contributor

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 4c45673 into master Oct 18, 2022
@paritytech-processbot paritytech-processbot bot deleted the bkchr-prepare-new-clippy branch October 18, 2022 10:07
chevdor pushed a commit that referenced this pull request Oct 24, 2022
@bkchr @chevdor
Prepare for latest clippy (nightly 09-10-2022) (#12466)
a0469b6
@chevdor chevdor mentioned this pull request Oct 24, 2022
Closed
@AurevoirXavier AurevoirXavier mentioned this pull request Jan 10, 2023
Closed
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@bkchr @ark0f
Prepare for latest clippy (nightly 09-10-2022) (paritytech#12466)
3d27f2a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@rcny rcny rcny approved these changes

@andresilva andresilva andresilva approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bkchr @andresilva @rcny @ggwpez