Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix flaky service test #12472

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Fix flaky service test #12472

merged 1 commit into from
Oct 11, 2022

Conversation

altonen
Copy link
Contributor

@altonen altonen commented Oct 11, 2022

Sometimes NotificationStreamOpenened would be received for the other protocol before SyncConnected was received so when the connection was closed, an incorrect event was read from the event stream.

Also added a comment about the handshake field in NonDefaultSetConfig. I hope that proper handshake support can be added soon so that comment won't stay there for long.

Sometimes `NotificationStreamOpenened` would be received for the
other protocol before `SyncConnected` was received so when the
connection was closed, an incorrect event was read from the event
stream.
@altonen altonen added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Oct 11, 2022
@dmitry-markin
Copy link
Contributor

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 6072b90 into master Oct 11, 2022
@paritytech-processbot paritytech-processbot bot deleted the fix-flaky-service-test branch October 11, 2022 15:25
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
Sometimes `NotificationStreamOpenened` would be received for the
other protocol before `SyncConnected` was received so when the
connection was closed, an incorrect event was read from the event
stream.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
Status: Done
Status: done
Development

Successfully merging this pull request may close these issues.

3 participants