This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
derive Serialize/Deserialize for BeefyAuthoritySet #12516
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serban300
added
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
labels
Oct 18, 2022
svyatonik
approved these changes
Oct 18, 2022
bkchr
approved these changes
Oct 18, 2022
bot merge |
Waiting for commit status. |
Merge cancelled due to error. Error: Statuses failed for 263cc3f |
acatangiu
approved these changes
Oct 18, 2022
bot merge |
Waiting for commit status. |
Merge cancelled due to error. Error: Statuses failed for 263cc3f |
bot rebase |
Error: Command 'Command { std: "git" "push" "--porcelain" "serban300" "small_fixes", kill_on_drop: false }' failed with status Some(1); output: error: failed to push some refs to 'https://x-access-token:${SECRET}@github.com/serban300/substrate.git' |
serban300
added a commit
that referenced
this pull request
Oct 20, 2022
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: paritytech/parity-bridges-common#2469
We are working on implementing BEEFY finality in the bridges project and as part of this we'll need to have the initial
BeefyAuthoritySet
in theGenesisConfig
structure. In order to do this we needBeefyAuthoritySet
to implement serde serialize/deserialize.