Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

cumulus v0.9.30 cherry pick bench fix from master #12543

Closed

Conversation

muharem
Copy link
Contributor

@muharem muharem commented Oct 21, 2022

Cherry pick the benchmarks fix from master
Fix PR #12482

substrate companion branch: cumulus-v0.9.30
polkadot companion branch: release-v0.9.30
cumulus companion branch: polkadot-v0.9.30

…ive (#12482)

* Force base weights to be the minimum only when the intercept is negative; emit minimum execution times

* Add an `assert` making sure the intercept is zero when it's supposed to be zero

* Fix template

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* ".git/.scripts/bench-bot.sh" pallet dev pallet_assets

* ".git/.scripts/bench-bot.sh" pallet dev pallet_uniques

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: command-bot <>
@muharem muharem added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. labels Oct 21, 2022
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI shows a merge conflict but GitHub does not…

@EgorPopelyaev EgorPopelyaev added the C1-low PR touches the given topic and has a low impact on builders. label Oct 21, 2022
@chevdor
Copy link
Contributor

chevdor commented Oct 24, 2022

Let's not modify the polkadot-v0.9.30 branch as Polkadot v0.9.30 was already released.
Can you edit this PR against https://github.com/paritytech/substrate/tree/cumulus-v0.9.30 please ?

@muharem muharem changed the base branch from polkadot-v0.9.30 to cumulus-v0.9.30 October 24, 2022 13:13
@muharem muharem changed the title polkadot v0.9.30 cherry pick bench fix from master cumulus v0.9.30 cherry pick bench fix from master Oct 24, 2022
@muharem
Copy link
Contributor Author

muharem commented Oct 24, 2022

Let's not modify the polkadot-v0.9.30 branch as Polkadot v0.9.30 was already released. Can you edit this PR against https://github.com/paritytech/substrate/tree/cumulus-v0.9.30 please ?

done

@chevdor
Copy link
Contributor

chevdor commented Oct 24, 2022

After a bit of convincing, our CI turned green on a few more points:
https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines/222413

@chevdor
Copy link
Contributor

chevdor commented Oct 24, 2022

cargo test --no-run --message-format json-render-diagnostics --workspace --exclude node-cli --release --features runtime-benchmarks --locked

passed locally.

@alvicsam alvicsam requested a review from a team as a code owner October 24, 2022 14:44
@chevdor
Copy link
Contributor

chevdor commented Oct 24, 2022

This PR #12556 should fix the clippy issues

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants