Only ensure parent finalization when the parent isn't already finalized #12615
Conversation
|
User @kayabaNerve, please sign the CLA here. |
|
Is there a more limited CLA available? I'm perfectly fine waiving/transferring the copyright on this patch (if it even has copyright. It's so minimal it'd be hard to argue that) and any others I submit via a Parity-managed source control solution, yet I don't appreciate any code relating to Substrate (the "Work") I simply discuss ("for the purpose of discussing and improving the Work") with a Parity employee ("any form of electronic, verbal, or written communication sent to Us or our representatives") also having its copyright transferred (unless I explicitly mark every conversation as "Not a Contribution"). |
|
@kayabaNerve there is no simple CLA. Sorry. |
bkchr
added
A2-insubstantial
|
@kayabaNerve would it still be possible that you sign the CLA? |
|
Considering this applies to all prior submitted work, and multiple personal conversations of mine would be re-classified as submissions, signing that CLA (in the worst case scenario) would amount to signing over the IP of most of my project due to how vague it is and lacking in scope. There's also the further issue where affiliate repos are also included, yet any group Parity exhibits some level of managerial control over can be argued as an affiliate, so as someone applying for the SBP, there's a chance I could be argued as an affiliate (in a worst case scenario) if I sign any agreements, and my entire project becomes licensed to Parity. While I don't believe that'd hold up in a court of law, I don't want to provide the opportunity for the argument and I do want to highlight the problems with this agreement (while I'm already talking with Parity about the SBP agreement for similar reasons). Finally, there's no option to revoke the CLA. While I don't believe a contract can stand perpetually, regardless of intent to terminate (though I'm not a lawyer and come from a US background), I would sign this (if it wasn't scoped to my entire past) and just immediately revoke it to move forward, While I understand Parity is a large organization prioritizing a universal flow which has been legally vetted, and I believe I understand the intent of a lot of the verbage in the contract, I cannot sign it due to the implications on not only myself, yet the open source project I lead. While this could lead to further discussions on the CLA in general*, or an exception for me personally, it could also lead to this patch (which I don't believe is substantial enough it can be argued to be copyrightable) being unaccepted. Considering I have applied it to my fork, that'd be unfortunate yet not unacceptable. In the interest of moving forward, I agree to waive all claims of copyright, ownership, intellectual property, and associated rights to the Git commit identified by hash 803b11c. While I'm unsure if that is sufficient to move forward on this PR alone, I hope it may be. As a side note, I just saw you raised I did not have to re-request the info as it was already available. Sorry, I missed that 😅 I would offer to submit a new commit correcting that, yet I think the amount of paperwork involved if I do it from my end means it's best left to you. *For me to want to sign this CLA, I'd request it only include:
This resolves most ambiguity and maintains focus. I'd also hope for it to be comprehensive in most cases. |
|
Okay @kayabaNerve. Superseded by: #12653 |
Fixes #12614.
I'm unsure if this is the optimal edit, yet apply_finality is exposed to external APIs. Accordingly, I didn't want to remove the warning, which seemed sane. Just this flippant call which triggered it without meaning.
cargo fmtwas run to ensure it complies with style.