This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cli: Improve pruning documentation #12819
cli: Improve pruning documentation #12819
Changes from 3 commits
7ece645
fdbc9a0
804aff6
eb579bc
7eb7956
8da7e10
9cf6f5e
9379757
5356629
f25b491
e3ffe3e
a4e88bf
aee8844
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should change this to:
Then add the following enum:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that does make sense! Thanks for the suggestion!
One problem with
ValueEnum
is that its happy with unit only enum variants. This is related to the value_variants that requires us to state the expected values. If theCustom(32)
is omitted, the default value of "256" cannot be provided anymore.To overcome this I've changed the
ValueEnum
toFromStr
.Let me know what you think of it