Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Mmr persist state #12822

Merged
merged 9 commits into from
Dec 7, 2022
Merged

Mmr persist state #12822

merged 9 commits into from
Dec 7, 2022

Conversation

acatangiu
Copy link
Contributor

Persisting gadget state across runs.

Fixes #12780

@acatangiu acatangiu added A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels Dec 1, 2022
@acatangiu acatangiu self-assigned this Dec 1, 2022
Signed-off-by: acatangiu <adrian@parity.io>
@acatangiu acatangiu added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Dec 2, 2022
Copy link
Contributor

@svyatonik svyatonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

client/merkle-mountain-range/src/aux_schema.rs Outdated Show resolved Hide resolved
client/merkle-mountain-range/src/lib.rs Outdated Show resolved Hide resolved
@acatangiu acatangiu merged commit 0d153c9 into paritytech:master Dec 7, 2022
@acatangiu acatangiu deleted the mmr-persist-state branch December 7, 2022 10:20
ltfschoen pushed a commit to ltfschoen/substrate that referenced this pull request Feb 22, 2023
client/mmr: persisting gadget state across runs

Fixes paritytech#12780

* client/mmr: on init do canonicalization catch-up

* client/mmr: add more tests

* client/mmr: persist gadget progress in aux db

* client/mmr: add more tests

* client/mmr: replace async_std with tokio

* remove leftover comment

* address review comments

Signed-off-by: acatangiu <adrian@parity.io>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
client/mmr: persisting gadget state across runs

Fixes paritytech#12780

* client/mmr: on init do canonicalization catch-up

* client/mmr: add more tests

* client/mmr: persist gadget progress in aux db

* client/mmr: add more tests

* client/mmr: replace async_std with tokio

* remove leftover comment

* address review comments

Signed-off-by: acatangiu <adrian@parity.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client/mmr: make it resilient to finality notifications loss
3 participants