Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Node template isn't licensed, remove left-over GPL header #12937

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Node template isn't licensed, remove left-over GPL header #12937

merged 1 commit into from
Dec 15, 2022

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Dec 15, 2022

Closes: #12936

@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Dec 15, 2022
@bkchr bkchr requested a review from ggwpez December 15, 2022 08:02
@revoltez
Copy link

so this means substrate does not depend on any GPL code whatsoever and the GPL in that benchmarking file was just a mistake?

@bkchr
Copy link
Member Author

bkchr commented Dec 15, 2022

so this means substrate does not depend on any GPL code whatsoever and the GPL in that benchmarking file was just a mistake?

We also have GPL3 code. However, I'm no lawyer knowing the exact details on how this works. Sorry. I just know that the node template is not licensed and this file was probably just copied.

@ggwpez
Copy link
Member

ggwpez commented Dec 15, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit f050628 into master Dec 15, 2022
@paritytech-processbot paritytech-processbot bot deleted the bkchr-remove-wrong-license branch December 15, 2022 13:06
@AurevoirXavier AurevoirXavier mentioned this pull request Feb 8, 2023
Closed
@kacperzuk-neti kacperzuk-neti mentioned this pull request Feb 14, 2023
Merged
ltfschoen pushed a commit to ltfschoen/substrate that referenced this pull request Feb 22, 2023
@bkchr @ltfschoen
Node template isn't licensed, remove left-over GPL header (paritytech…
907a564 
…#12937)
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@bkchr @ark0f
Node template isn't licensed, remove left-over GPL header (paritytech…
7501eed 
…#12937)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SkymanOne SkymanOne SkymanOne approved these changes

@ggwpez ggwpez ggwpez approved these changes

@Wiezzel Wiezzel Wiezzel approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Licence conflict between GPL and Unlicenced in the node template
5 participants
@bkchr @revoltez @ggwpez @Wiezzel @SkymanOne