Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Alliance: remove unused func from weight trait #13001

Merged
merged 3 commits into from
Dec 22, 2022
Merged

Alliance: remove unused func from weight trait #13001

merged 3 commits into from
Dec 22, 2022

Conversation

muharem
Copy link
Contributor

@muharem muharem commented Dec 22, 2022 •
edited
Loading

Follow up for #12762

cumulus companion: paritytech/cumulus#2030

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Dec 22, 2022
@muharem muharem added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Dec 22, 2022
@muharem muharem mentioned this pull request Dec 22, 2022
Merged
@ggwpez
Copy link
Member

ggwpez commented Dec 22, 2022

This should not be necessary to do manually, it rather means that the weights were not re-generated in the original MR.

@ggwpez
Copy link
Member

ggwpez commented Dec 22, 2022

/cmd queue -c bench-bot $ pallet dev pallet_alliance

@command-bot
Copy link

command-bot bot commented Dec 22, 2022 •
edited
Loading

@ggwpez https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2188610 was started for your command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_alliance. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment /cmd cancel 128-57991d75-a58f-47ce-952e-fa14f34a87a2 to cancel this command or /cmd cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Dec 22, 2022

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_alliance has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2188610 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2188610/artifacts/download.

@muharem muharem requested a review from ggwpez December 22, 2022 19:37
@ggwpez
Copy link
Member

ggwpez commented Dec 22, 2022

bot merge

@paritytech-processbot
Copy link

Error: "Check reviews" status is not passing for paritytech/cumulus#2030

@ggwpez
Copy link
Member

ggwpez commented Dec 22, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 91d91d1 into master Dec 22, 2022
@paritytech-processbot paritytech-processbot bot deleted the muharem-fix-alliance-remove-unused-weight branch December 22, 2022 20:12
@AurevoirXavier AurevoirXavier mentioned this pull request Feb 8, 2023
Closed
@kacperzuk-neti kacperzuk-neti mentioned this pull request Feb 14, 2023
Merged
ltfschoen pushed a commit to ltfschoen/substrate that referenced this pull request Feb 22, 2023
@muharem @ltfschoen
Alliance: remove unused func from weight trait (paritytech#13001)
062e7c7 
* Alliance: remove unused weight func

* ".git/.scripts/bench-bot.sh" pallet dev pallet_alliance

Co-authored-by: command-bot <>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@muharem @ark0f
Alliance: remove unused func from weight trait (paritytech#13001)
9231092 
* Alliance: remove unused weight func

* ".git/.scripts/bench-bot.sh" pallet dev pallet_alliance

Co-authored-by: command-bot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@joepetrowski joepetrowski joepetrowski approved these changes

@gilescope gilescope Awaiting requested review from gilescope

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muharem @ggwpez @joepetrowski