This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
service: storage monitor added #13082
service: storage monitor added #13082
Changes from 7 commits
34577eb
b5f970b
37bbba4
ba0f28f
e360685
fd5679f
217234f
8b3310b
931339c
c200159
f5501f2
45171dc
f346394
eb49400
8619766
a0cd44d
d3f143c
a79af9a
00e7264
6c3eb1c
58dcf55
95b576b
0b8697e
c0fc2ca
de35dda
4e32f3d
0578588
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is
statvfs
syscall called inside, so maybe this should bespawn_blocking
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea how long this takes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on my pc test running for few minutes: typically few µs, sometimes several dozes µs, rarely hundreds.
Histogram (in
nanoseconds
):Still, even it is low on average, sometimes it can block for a little bit longer (0.12ms). Probably non-blocking spawn would be fine here. Let's give it a try.