Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix longest chain finalization target lookup #13289

Merged
merged 14 commits into from
Feb 11, 2023
Merged

Fix longest chain finalization target lookup #13289

merged 14 commits into from
Feb 11, 2023

Commits on Jan 31, 2023

  1. Finalization target should be chosed as some ancestor of SelectChain:… 

    …:best_chain
    @davxy
    davxy committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    0c20c82 View commit details
    Browse the repository at this point in the history

  2. More test assertions

    @davxy
    davxy committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    3723717 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2023

  1. Improve docs

    @davxy
    davxy committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    a6ee614 View commit details
    Browse the repository at this point in the history

  2. Removed stale docs

    @davxy
    davxy committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    865a097 View commit details
    Browse the repository at this point in the history

  3. Rename 'target' to 'base' in lookup method

    @davxy
    davxy committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    7f1b5f5 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. Fix typo

    @davxy
    davxy committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    28128cf View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. Apply suggestions from code review 

    Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
    @davxy @andresilva
    davxy and andresilva authored Feb 7, 2023
    Configuration menu
    Copy the full SHA
    2ebf7e5 View commit details
    Browse the repository at this point in the history

  2. Rename 'target_hash' to 'base_hash' in 'SelectChain::finality_target()'

    @davxy
    davxy committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    5226f9d View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Anton <anton.kalyaev@gmail.com>
    @davxy @melekes
    davxy and melekes authored Feb 8, 2023
    Configuration menu
    Copy the full SHA
    a21a311 View commit details
    Browse the repository at this point in the history

  2. Docs improvement

    @davxy
    davxy committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    5512c05 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into fix-longest-chain-finalization-target

    @davxy
    davxy committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    323e70a View commit details
    Browse the repository at this point in the history

  4. Doc fix

    @davxy
    davxy committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    85aa43c View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Bastian Köcher <git@kchr.de>
    @davxy @bkchr
    davxy and bkchr authored Feb 11, 2023
    Configuration menu
    Copy the full SHA
    013f303 View commit details
    Browse the repository at this point in the history

  2. Apply more code suggestions

    @davxy
    davxy committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    89ea0b8 View commit details
    Browse the repository at this point in the history