This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Support the subscription of every imported block #13372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuchengxu
changed the title
bkchr
suggested changes
Feb 13, 2023
… block-import-notification-for-every-block
… block-import-notification-for-every-block
… block-import-notification-for-every-block
|
Kindly ping @bkchr |
melekes
reviewed
Feb 23, 2023
… block-import-notification-for-every-block
bkchr
reviewed
Feb 23, 2023
Please also merge master to make CI happy. |
bkchr
added
A0-please_review
… block-import-notification-for-every-block
… block-import-notification-for-every-block
… block-import-notification-for-every-block
… block-import-notification-for-every-block
|
bot merge |
|
Waiting for commit status. |
1 task
ukint-vs
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Apr 10, 2023
* Support the subscription of every import block Close paritytech#13315 * Clean up any closed block import notification sinks * Apply review suggestions * Nit * `every_block_import_notification_sinks` -> `every_import_notification_sinks` * Apply review suggestions
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* Support the subscription of every import block Close paritytech#13315 * Clean up any closed block import notification sinks * Apply review suggestions * Nit * `every_block_import_notification_sinks` -> `every_import_notification_sinks` * Apply review suggestions
Closed
46 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new method
every_import_notification_streamto the traitBlockchainEventsso that users can subscribe to every imported block in addition to the existing block import notification which is only fired on full synced or reorg.Closes #13315