This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Keystore overhaul #13615
Merged
Keystore overhaul #13615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davxy
added
A0-please_review
skunert
reviewed
Mar 16, 2023
skunert
approved these changes
Mar 16, 2023
|
bot merge |
|
Error: "Check reviews" status is not passing for paritytech/polkadot#6892 |
michalkucharczyk
approved these changes
Mar 17, 2023
|
bot merge |
1 task
breathx
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Apr 22, 2023
* Remove 'supported_keys' 'sign_with_any' and 'sign_with_all' from keystore trait * Remove the aync keystore * Renaming: - SyncCryptoStore -> Keystore - SyncCryptoStorePtr -> KeystorePtr - KeyStore -> MemoryKeystore * Fix authority discovery worker and tests * Rename 'insert_unknown' to 'insert' * Remove leftover
15 tasks
AurevoirXavier
added a commit
to darwinia-network/darwinia
that referenced
this pull request
Jul 11, 2023
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* Remove 'supported_keys' 'sign_with_any' and 'sign_with_all' from keystore trait * Remove the aync keystore * Renaming: - SyncCryptoStore -> Keystore - SyncCryptoStorePtr -> KeystorePtr - KeyStore -> MemoryKeystore * Fix authority discovery worker and tests * Rename 'insert_unknown' to 'insert' * Remove leftover
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially address #13556
This PR is part of a small overhaul of the keystore related traits and structures.
A followup PR will focus on the keystore methods... I prefer to keep this PR small and quickly reviewable
Mostly delivers:
CryptoStoreasync trait.It was introduced a long ago in the hope of a remote keystore.
Today the 90% of our code still depend on the sync version thus there's not point of having it around. If one day™️ it will be really required then well can trivially reintroduce it.
But in the meantime is better to have no bloat in an already giant repo.
SyncCryptoStore->KeystoreCryptoStore→ removed 🔴SyncCryptoKeyStorePtr→KeystorePtrtesting::KeyStore→testing::MemoryKeystore(this is what it is and is more inline with the other implementation we provide:LocalKeystore).sign_with_anyandsign_with_allNOTE: big part of the changes spread through the project are due to the renamings 🫤.
polkadot companion: paritytech/polkadot#6892
cumulus companion: paritytech/cumulus#2336