Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

MQ pallet: add discard_overweight call #13877

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

MQ pallet: add discard_overweight call #13877

wants to merge 24 commits into from

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Apr 11, 2023 •
edited
Loading

Changes:

  • Adds a discard_overweight call to the MQ pallet for polkadot#6271 to discard overweight (but not yet stale) messages. The reap_page functionality to remove stale pages is not sufficient in the case that the number of max-stale pages is not reachable by the maximal number of configured messages. This allows to still remove overweight messages and not clog up the queue.
  • Adds a discard_overweight to the ServiceQueues trait.
  • Adds AsEnsureOriginWithContainsPair: An EnsureOrigin that is filtered through a ContainsPair predicate.
  • Adds EitherOfWithArg: A homogenous typed EitherOf that additionally takes an argument.

Context

The DiscardOverweightOrigin will be configured in Polkadot to allow each parachain's sovereign account to discard overweight messages from their UMP queue.

ggwpez added 7 commits April 11, 2023 14:45
@ggwpez
Add discard_overweight
1e87aaf 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Merge remote-tracking branch 'origin/master' into oty-mq-discard-over…
faa51bb 
…weight
@ggwpez
Comment
c312c95 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Dynamic seed for integration tests
e2e06ac 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Result for note_processed_at_pos
ee9c5d9 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Cleanup
57aab39 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Tests
1d2cca6 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez marked this pull request as ready for review April 15, 2023 21:50
ggwpez added 4 commits April 16, 2023 00:16
@ggwpez
Prefer 'core' over 'sp_std'
94e5a42 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Fixup origins
39b0f5b 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Merge remote-tracking branch 'origin/master' into oty-mq-discard-over…
6dc6e2b 
…weight
@ggwpez
fmt
c72a39a 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited B1-note_worthy Changes should be noted in the release notes T1-runtime This PR/Issue is related to the topic “runtime”. labels Apr 15, 2023
@ggwpez
Clippy
8572fe9 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez requested a review from gavofyork April 15, 2023 22:28
@ggwpez
Copy link
Member Author

ggwpez commented Apr 15, 2023

bot bench $ pallet dev pallet_message_queue

@paritytech paritytech deleted a comment from command-bot bot Apr 15, 2023
@paritytech paritytech deleted a comment from command-bot bot Apr 15, 2023
ggwpez added 2 commits April 17, 2023 11:37
@ggwpez
Fix CI
158b2d0 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Merge remote-tracking branch 'origin/master' into oty-mq-discard-over…
9c70cb4 
…weight
@ggwpez ggwpez changed the title MQ pallet: add discard overweight call MQ pallet: add discard_overweight call Apr 17, 2023
@ggwpez ggwpez self-assigned this Apr 17, 2023
@kianenigma kianenigma requested review from gpestana and sam0x17 May 1, 2023 10:04
@kianenigma kianenigma self-requested a review May 1, 2023 10:04
sam0x17
sam0x17 approved these changes May 1, 2023
View reviewed changes
Copy link
Contributor

@sam0x17 sam0x17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, just a few nits and questions

frame/message-queue/src/benchmarking.rs Outdated Show resolved Hide resolved
frame/system/src/lib.rs Outdated Show resolved Hide resolved
@ggwpez ggwpez mentioned this pull request May 12, 2023
Merged
12 tasks
@muharem muharem self-requested a review May 16, 2023 11:48
ggwpez added 3 commits May 17, 2023 17:28
@ggwpez
Merge remote-tracking branch 'origin/master' into oty-mq-discard-over…
8acab6d 
…weight
@ggwpez
Add extrinsic_call
5bb4dad 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Remove WIP code
4b75bca 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez requested a review from a team May 17, 2023 15:39
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2852750

muharem
muharem reviewed May 22, 2023
View reviewed changes
frame/message-queue/src/lib.rs Outdated Show resolved Hide resolved
frame/message-queue/src/lib.rs Outdated Show resolved Hide resolved
frame/support/src/traits/messages.rs Show resolved Hide resolved
ggwpez added 3 commits June 6, 2023 11:58
@ggwpez
Merge remote-tracking branch 'origin/master' into oty-mq-discard-over…
5114a98 
…weight
@ggwpez
impl Morph for ()
76515d4 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Fix build
4032aed 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez requested a review from a team June 6, 2023 10:26
ggwpez added 2 commits June 6, 2023 15:47
@ggwpez
Review
70fa9ba 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Review
0ead646 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@muharem muharem muharem approved these changes

@sam0x17 sam0x17 sam0x17 approved these changes

@gavofyork gavofyork Awaiting requested review from gavofyork

@gpestana gpestana Awaiting requested review from gpestana

@kianenigma kianenigma Awaiting requested review from kianenigma

At least 2 approving reviews are required to merge this pull request.

Assignees

@ggwpez ggwpez

Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
Runtime / FRAME
Status: In Progress
Security Audit (PRs) - SRLabs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ggwpez @paritytech-cicd-pr @sam0x17 @muharem