Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

replace unused cargo-deny check with a new cargo-deny-licenses job #13956

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

altaua
Copy link
Contributor

@altaua altaua commented Apr 19, 2023

The old cargo-deny job had been broken and disabled for a long time, and per internal discussion there doesn't seem to be any interest in fixing it and actually using the job output for anything.

The new job will run on all PRs and only use cargo deny's facility for detecting dependencies with problematic licenses, as requested in https://github.com/paritytech/ci_cd/issues/777.

Unverified

No user is associated with the committer email.
It's been broken and disabled for quite a while, and per internal
discussion there doesn't seem to be any interest in fixing it and
actually using the job output for anything.
@altaua altaua added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Apr 19, 2023
@altaua altaua self-assigned this Apr 19, 2023
It'll run on all PRs and fail if external dependencies with unsuitable
licenses are detected.
@altaua altaua marked this pull request as ready for review April 20, 2023 11:22
@altaua altaua requested a review from a team as a code owner April 20, 2023 11:22
@paritytech-ci paritytech-ci requested a review from a team April 20, 2023 11:28
@altaua altaua merged commit 532edcf into master Apr 20, 2023
@altaua altaua deleted the mira/cargo-deny branch April 20, 2023 12:03
@ggwpez ggwpez mentioned this pull request Apr 20, 2023
@arkpar
Copy link
Member

arkpar commented Apr 25, 2023

Substrate current licensing policy is:
GPL-3.0 WITH Classpath-exception-2.0 for stuff under /client
Apache2 for everything else.

I've added a crate under client and it took me a while to figure out why CI is failing and find this PR. The exception list should be generated automatically or at least the CI job should point developers to where they need to add exceptions.

nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
…aritytech#13956)

* ci: remove the cargo-deny job

It's been broken and disabled for quite a while, and per internal
discussion there doesn't seem to be any interest in fixing it and
actually using the job output for anything.

* ci: add new cargo-deny-licenses job

It'll run on all PRs and fail if external dependencies with unsuitable
licenses are detected.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants