This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #13384
It changed the
rpc_port
from aOption<u16> -> u16
which broke overriding it in cumulus (see paritytech/cumulus#2529) as the default value was used insteadSo let's expose
rpc_interface
so others can override the default port besides using the CLI--rpc-port
We could also revert port to be an option again but I would prefer to keep it port as u16 because it's simplifies the code in substrate but makes it a bit annoying to override (by comparing the port to the default sc_cli::RPC_DEFAULT_PORT)
polkadot companion: paritytech/polkadot#7190
cumulus companion: paritytech/cumulus#2538