Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

cli: make rpc_interface re-useable #14087

Closed
wants to merge 4 commits into from

Conversation

niklasad1
Copy link
Member

@niklasad1 niklasad1 commented May 6, 2023

Follow-up on #13384

It changed the rpc_port from a Option<u16> -> u16 which broke overriding it in cumulus (see paritytech/cumulus#2529) as the default value was used instead

So let's expose rpc_interface so others can override the default port besides using the CLI --rpc-port

We could also revert port to be an option again but I would prefer to keep it port as u16 because it's simplifies the code in substrate but makes it a bit annoying to override (by comparing the port to the default sc_cli::RPC_DEFAULT_PORT)

polkadot companion: paritytech/polkadot#7190
cumulus companion: paritytech/cumulus#2538

@niklasad1 niklasad1 added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels May 6, 2023
@niklasad1
Copy link
Member Author

niklasad1 commented May 7, 2023

let's do it with an option instead I don't like this anyway, I realized it will make the structopt docs weird

@niklasad1 niklasad1 closed this May 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant