Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Bump kvdb-rocksdb to 0.19.0 #14113

Merged
merged 1 commit into from
May 10, 2023
Merged

Bump kvdb-rocksdb to 0.19.0 #14113

merged 1 commit into from
May 10, 2023

Conversation

tdimitrov
Copy link
Contributor

@tdimitrov tdimitrov commented May 10, 2023 •
edited
Loading

polkadot companion: paritytech/polkadot#7212

@tdimitrov tdimitrov added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels May 10, 2023
ordian
ordian approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is likely need a polkadot companion.

@tdimitrov tdimitrov mentioned this pull request May 10, 2023
Merged
@tdimitrov
Copy link
Contributor Author

How do we handle changes depending on each other?

kvdb-rocksdb should be bumped in polkadot but it won't compile until substrate is also bumped 🙈

@tdimitrov
Copy link
Contributor Author

And cumulus fails because polkadot-service needs to be bumped with the companion above.

@ordian
Copy link
Member

ordian commented May 10, 2023

bot merge

@paritytech-processbot
Copy link

Error: "Check reviews" status is not passing for paritytech/polkadot#7212

@niklasad1
Copy link
Member

bot merge

@paritytech-processbot
Copy link

Error: "Check reviews" status is not passing for paritytech/polkadot#7212

@ordian
Copy link
Member

ordian commented May 10, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit e2c5a56 into master May 10, 2023
@paritytech-processbot paritytech-processbot bot deleted the tsv-bump-kvdb-rocksdb branch May 10, 2023 14:11
niklasad1 pushed a commit that referenced this pull request May 17, 2023
@tdimitrov @niklasad1
Bump kvdb-rocksdb to 0.19.0 (#14113)
b8ed4bf
@kiltbot kiltbot mentioned this pull request Jun 21, 2023
Closed
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@tdimitrov @nathanwhit
Bump kvdb-rocksdb to 0.19.0 (paritytech#14113)
688314c
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tdimitrov @ordian @niklasad1 @bkchr