Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

expose transport, peer_info and discovery in sc-network #14132

Merged
merged 3 commits into from
May 15, 2023

Conversation

klbrvik
Copy link
Contributor

@klbrvik klbrvik commented May 12, 2023

What does it do?

Makes discovery, peer_info and transport mods public in sc-network.

Why?

Makes it easy to develop lightweight binaries that want to become of libp2p swarm and use libp2p's NetworkBehaviours.

@cla-bot-2021
Copy link

cla-bot-2021 bot commented May 12, 2023

User @klbrvik, please sign the CLA here.

@bkchr bkchr requested a review from a team May 12, 2023 20:12
@altonen altonen requested a review from a team May 15, 2023 08:31
@bkchr
Copy link
Member

bkchr commented May 15, 2023

@klbrvik can we move on with this?

@klbrvik
Copy link
Contributor Author

klbrvik commented May 15, 2023

@bkchr some CI checks were failing, as soon as they pass I'm moving from Draft to Ready for review

@klbrvik klbrvik marked this pull request as ready for review May 15, 2023 20:30
@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 15, 2023
@bkchr
Copy link
Member

bkchr commented May 15, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 2af3ba8 into paritytech:master May 15, 2023
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
…4132)

* expose transport, peer_info and discovery in sc-network

* fix fmt

* add missing module docs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants