This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Migration hook fixes #14174
Merged
Migration hook fixes #14174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamaharon
commented
May 18, 2023
Comment on lines
552
to
566
| ensure!( | ||
| BondedPools::<T>::iter().all(|(_, inner)| inner.commission.current.is_none() && | ||
| inner.commission.max.is_none() && | ||
| inner.commission.change_rate.is_none() && | ||
| inner.commission.throttle_from.is_none()), | ||
| "a commission value has been incorrectly set" | ||
| BondedPools::<T>::iter().all(|(_, inner)| | ||
| // Check current | ||
| (inner.commission.current.is_none() || | ||
| inner.commission.current.is_some()) && | ||
| // Check max | ||
| (inner.commission.max.is_none() || inner.commission.max.is_some()) && | ||
| // Check change_rate | ||
| (inner.commission.change_rate.is_none() || | ||
| inner.commission.change_rate.is_some()) && | ||
| // Check throttle_from | ||
| (inner.commission.throttle_from.is_none() || | ||
| inner.commission.throttle_from.is_some())), | ||
| "a commission value has not been set correctly" | ||
| ); |
There was a problem hiding this comment.
This ensure! was failing on Rococo I guess because commission became no longer None for everything after people started using the pallet.
But the checks seem kind of like a noop (checking is_some || is_none). Can we just remove them?
liamaharon
added
A0-please_review
This was referenced May 18, 2023
bkchr
approved these changes
May 19, 2023
…gration-hook-fixes
Co-authored-by: Bastian Köcher <git@kchr.de>
liamaharon
changed the title
ChildBounties storage version & migration hook fixes
sam0x17
approved these changes
May 23, 2023
|
bot merge |
9 tasks
gpestana
pushed a commit
that referenced
this pull request
May 27, 2023
* fix offences pre_upgrade hook * identify source of ensure! failures * stop migration hooks breaking post migration * add childbounties storage version * init child bounties version to zero * Update frame/child-bounties/src/lib.rs Co-authored-by: Bastian Köcher <git@kchr.de> * remove redundant preupgrade version checks * update test * fix nom pools v3 migration * kick ci * kick ci --------- Co-authored-by: Bastian Köcher <git@kchr.de>
15 tasks
Ank4n
pushed a commit
that referenced
this pull request
Jul 8, 2023
* fix offences pre_upgrade hook * identify source of ensure! failures * stop migration hooks breaking post migration * add childbounties storage version * init child bounties version to zero * Update frame/child-bounties/src/lib.rs Co-authored-by: Bastian Köcher <git@kchr.de> * remove redundant preupgrade version checks * update test * fix nom pools v3 migration * kick ci * kick ci --------- Co-authored-by: Bastian Köcher <git@kchr.de>
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* fix offences pre_upgrade hook * identify source of ensure! failures * stop migration hooks breaking post migration * add childbounties storage version * init child bounties version to zero * Update frame/child-bounties/src/lib.rs Co-authored-by: Bastian Köcher <git@kchr.de> * remove redundant preupgrade version checks * update test * fix nom pools v3 migration * kick ci * kick ci --------- Co-authored-by: Bastian Köcher <git@kchr.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial paritytech/polkadot#7187
Partial paritytech/polkadot#6657
Add#[pallet::storage_version(STORAGE_VERSION)]toChildBountiespalletTogether with paritytech/polkadot#7251, this fixes all storage / migration hook issues on Rococo & Westend (also verified Polkadata & Kusama still work).