Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

wasm: Update from v6.0.2 to v8.0.1 #14178

Merged
merged 3 commits into from
May 24, 2023
Merged

Conversation

lexnv
Copy link
Contributor

@lexnv lexnv commented May 19, 2023

Update wasmtime from v6.0.2 to v8.0.1.

Having an older version causes build errors in subxt with smoldot.
Subxt relies on sp-runtime which was bringing wasmtime v6.0.2, while smoldot has wasmtime v8.0.1.

This change reflects in sp-runtime, sp-core, sp-keyring primarily.

paritytech/subxt#965

polkadot companion: paritytech/polkadot#7268
cumulus companion: paritytech/cumulus#2623

// @paritytech/subxt-team

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 19, 2023
@lexnv lexnv requested a review from koute as a code owner May 19, 2023 13:09
@koute
Copy link
Contributor

koute commented May 19, 2023

Please wait with merging this; I need to run a few benchmarks first to make sure the performance has not regressed.

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv self-assigned this May 22, 2023
Copy link
Contributor

@koute koute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performance seems fine; LGTM!

@lexnv
Copy link
Contributor Author

lexnv commented May 24, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit e1345e7 into master May 24, 2023
@paritytech-processbot paritytech-processbot bot deleted the lexnv/update_wasm branch May 24, 2023 09:08
gpestana pushed a commit that referenced this pull request May 27, 2023
* wasm: Update from v6.0.2 to v8.0.1

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* Fix rustix version

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

---------

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Ank4n pushed a commit that referenced this pull request Jul 8, 2023
* wasm: Update from v6.0.2 to v8.0.1

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* Fix rustix version

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

---------

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
* wasm: Update from v6.0.2 to v8.0.1

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* Fix rustix version

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

---------

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants