This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix request-response protocols backpressure mechanism #14199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitry-markin
added
A0-please_review
altonen
approved these changes
May 24, 2023
|
bot merge |
gpestana
pushed a commit
that referenced
this pull request
May 27, 2023
15 tasks
Ank4n
pushed a commit
that referenced
this pull request
Jul 8, 2023
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14138 by replacing
futures::channel::mpsc::channelincoming request channel withasync_channel::bounded, which doesn't have a limitation that everySenderclone allocates an extra queue slot.polkadot companion: paritytech/polkadot#7276