Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[NFTs] Add minting price to the pre-signed mint object #14242

Merged
merged 2 commits into from
May 29, 2023

Conversation

jsidorenko
Copy link
Contributor

This PR adds a minting price to the PreSignedMint object.
This would allow to prepare a bunch of NFTs offchain, upload images to ipfs, prepare the metadata and set the mint price for the claimer as per each NFT.

@jsidorenko jsidorenko added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels May 26, 2023
@jsidorenko jsidorenko requested a review from a team May 26, 2023 20:15
Copy link
Contributor

@gilescope gilescope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsidorenko
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit f47a84a into master May 29, 2023
@paritytech-processbot paritytech-processbot bot deleted the js/offchain-mint-price branch May 29, 2023 11:00
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
)

* Add minting price to the pre-signed mint object

* Box the param
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants