This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Frame: Introduce TryConvert and MaybeConvert family of traits
#14297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
A0-please_review
ggwpez
approved these changes
Jun 2, 2023
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
bkchr
approved these changes
Jun 3, 2023
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Bastian Köcher <git@kchr.de>
gavofyork
commented
Jun 4, 2023
primitives/runtime/src/traits.rs
Outdated
| pub trait Convert<A, B> { | ||
| /// Make conversion. | ||
| fn convert(a: A) -> B; | ||
| } | ||
|
|
||
| /// Fallible conversion trait returning a Result. Generic over both source and destination types. |
There was a problem hiding this comment.
Suggested change
| /// Fallible conversion trait returning a Result. Generic over both source and destination types. | |
| /// Fallible conversion trait returning a [Result]. Generic over both source and destination types. |
gavofyork
commented
Jun 4, 2023
primitives/runtime/src/traits.rs
Outdated
| fn convert_back(b: B) -> A; | ||
| } | ||
|
|
||
| /// Fallible conversion trait returning a Result. Generic over both source and destination types. |
There was a problem hiding this comment.
Suggested change
| /// Fallible conversion trait returning a Result. Generic over both source and destination types. | |
| /// Fallible conversion trait returning a [Result]. Generic over both source and destination types. |
…e into gav-refactor-convert
librelois
added a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Jun 9, 2023
…ritytech#14297) * Frame: Introduce TryConvert and TryConvertBack * Update primitives/runtime/src/traits.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update primitives/runtime/src/traits.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update primitives/runtime/src/traits.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update primitives/runtime/src/traits.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update primitives/runtime/src/traits.rs Co-authored-by: Bastian Köcher <git@kchr.de> * Update primitives/runtime/src/traits.rs Co-authored-by: Bastian Köcher <git@kchr.de> * Add MaybeEquivalence * Docs --------- Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Bastian Köcher <git@kchr.de>
Agusrodri
pushed a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Jul 13, 2023
…ritytech#14297) * Frame: Introduce TryConvert and TryConvertBack * Update primitives/runtime/src/traits.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update primitives/runtime/src/traits.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update primitives/runtime/src/traits.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update primitives/runtime/src/traits.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update primitives/runtime/src/traits.rs Co-authored-by: Bastian Köcher <git@kchr.de> * Update primitives/runtime/src/traits.rs Co-authored-by: Bastian Köcher <git@kchr.de> * Add MaybeEquivalence * Docs --------- Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Bastian Köcher <git@kchr.de>
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…ritytech#14297) * Frame: Introduce TryConvert and TryConvertBack * Update primitives/runtime/src/traits.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update primitives/runtime/src/traits.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update primitives/runtime/src/traits.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update primitives/runtime/src/traits.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update primitives/runtime/src/traits.rs Co-authored-by: Bastian Köcher <git@kchr.de> * Update primitives/runtime/src/traits.rs Co-authored-by: Bastian Köcher <git@kchr.de> * Add MaybeEquivalence * Docs --------- Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Bastian Köcher <git@kchr.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These traits are helpful for cleaner code downstream in Polkadot.