Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

changes to nfts pallet for xcm integration #14395

Merged
merged 19 commits into from
Jul 25, 2023
Merged

changes to nfts pallet for xcm integration #14395

merged 19 commits into from
Jul 25, 2023

Conversation

vstam1
Copy link
Contributor

@vstam1 vstam1 commented Jun 15, 2023 •
edited
Loading

Fixes: #14349
Makes Incremental trait fallible and introduces new function in nfts-pallet to allow for non incremental collection ids.

  • Make Incremental fallible
  • Introduce create_collection_with_id function into non_fungibles_v2 Create trait
  • Testing
  • Benchmarking

@vstam1 vstam1 added A0-please_review Pull request needs code review. C3-medium PR touches the given topic and has a medium impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. B1-note_worthy Changes should be noted in the release notes labels Jun 16, 2023
@vstam1 vstam1 added the T1-runtime This PR/Issue is related to the topic “runtime”. label Jun 16, 2023
@vstam1 vstam1 marked this pull request as ready for review June 16, 2023 09:58
@vstam1 vstam1 requested a review from jsidorenko as a code owner June 16, 2023 09:58
@vstam1 vstam1 requested review from a team June 16, 2023 09:58
@takahser takahser mentioned this pull request Jun 19, 2023
Merged
10 tasks
ggwpez
ggwpez approved these changes Jun 20, 2023
View reviewed changes
frame/nfts/src/impl_nonfungibles.rs Show resolved Hide resolved
frame/support/src/traits/storage.rs Show resolved Hide resolved
@vstam1
Copy link
Contributor Author

vstam1 commented Jun 21, 2023

bot rebase

@paritytech-processbot
Copy link

Rebased

kianenigma
kianenigma reviewed Jun 22, 2023
View reviewed changes
frame/support/src/traits/storage.rs
pub trait Incrementable {
fn increment(&self) -> Self;
fn initial_value() -> Self;
pub trait Incrementable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undocumented functions? the trait docs are also off :D

kianenigma
kianenigma reviewed Jun 22, 2023
View reviewed changes
frame/nfts/src/lib.rs Outdated Show resolved Hide resolved
sacha-l
sacha-l reviewed Jul 3, 2023
View reviewed changes
Copy link
Contributor

@sacha-l sacha-l left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small doc review and suggestions - you might want to run a formatter on it so line wrapping is respected.

frame/support/src/traits/storage.rs Outdated Show resolved Hide resolved
frame/nfts/src/impl_nonfungibles.rs Outdated Show resolved Hide resolved
frame/asset-conversion/src/lib.rs Outdated Show resolved Hide resolved
frame/asset-conversion/src/lib.rs Show resolved Hide resolved
frame/nfts/src/lib.rs Show resolved Hide resolved
KiChjang
KiChjang suggested changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@KiChjang KiChjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot merge until the unwraps have been properly addressed.

@jsidorenko jsidorenko requested a review from KiChjang July 11, 2023 21:03
@vstam1
Copy link
Contributor Author

vstam1 commented Jul 24, 2023

bot rebase

@paritytech-processbot
Copy link

Rebased

@vstam1
Copy link
Contributor Author

vstam1 commented Jul 25, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit b9b1bbb into master Jul 25, 2023
@paritytech-processbot paritytech-processbot bot deleted the vstam1/nfts-pallet-xcm-integration branch July 25, 2023 08:02
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
@JesseAbram JesseAbram mentioned this pull request Oct 26, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sacha-l sacha-l sacha-l left review comments

@liamaharon liamaharon liamaharon left review comments

@kianenigma kianenigma kianenigma left review comments

@jsidorenko jsidorenko jsidorenko approved these changes

@sam0x17 sam0x17 sam0x17 left review comments

@ggwpez ggwpez ggwpez approved these changes

@franciscoaguirre franciscoaguirre franciscoaguirre approved these changes

@KiChjang KiChjang KiChjang approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C3-medium PR touches the given topic and has a medium impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration of the NFT pallet in XCM
9 participants
@vstam1 @sam0x17 @KiChjang @franciscoaguirre @jsidorenko @kianenigma @ggwpez @liamaharon @sacha-l