This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Some trivial externalities added #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepyakin
added
A3-in_progress
pepyakin
force-pushed
the
ser-a-bunch-of-externalities
branch
from
49bcd18
to
10a9c63
Compare
|
seems ok, but we'll want to do a proper audit of all this usage of scratch buffers. |
gavofyork
approved these changes
Jan 17, 2019
gavofyork
added
A6-seemsok
and removed
A0-please_review
MTDK1
pushed a commit
to bdevux/substrate
that referenced
this pull request
Apr 12, 2019
* Add gas_left, gas_price and balance externalities * Add a value_transferred externality
liuchengxu
pushed a commit
to liuchengxu/substrate
that referenced
this pull request
May 31, 2023
Remove extra FFTs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a several trivial to implement externality functions:
ext_value_transferredext_gas_priceext_gas_leftext_balanceThey are all similar in the sense that they return some property of a execution context. In each case the value is returned via the scratch buffer. This works, but is little awkward for
gas_leftin particular since some amount of noise might be introduced by the high-level language compiler between callinggas_leftand actually getting a value from it. It was discussed that we can actually constrainGastype to au64and just return it via a regular return value rather than (un)marshalling it through the scratch buffer but we decided to delay it for now.cc @Robbepop