This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
WasmExecutor flag to ignore onchain heappages value #14508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
approved these changes
Jul 7, 2023
bkchr
added
A0-please_review
|
Not sure why |
Not related to your changes. |
|
Anything preventing to merge it ? |
|
Yes, a second review :P @koute ?:) |
ggwpez
added
the
C1-low
koute
approved these changes
Jul 14, 2023
|
bot merge |
Agusrodri
pushed a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Jul 17, 2023
* WasmExecutor flag to ignore onchain heappages value * fmt
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* WasmExecutor flag to ignore onchain heappages value * fmt
Ank4n
pushed a commit
that referenced
this pull request
Jul 22, 2023
* WasmExecutor flag to ignore onchain heappages value * fmt
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ignore_onchain_heap_pagesflag toWasmExecutorBuilderto ignore the on-chain value of heap pages and use the default one.More info in paritytech/polkadot-sdk#71