This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Make peer evictions less aggressive #14619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original implementation of peer eviction prioritized aliveness over connection stability which made the peer count unstable for some users. As this may cause discomfort or infrastructure alerts if stability is tracked, adjust the eviction to be less aggressive by only evicting peers when the node has fully stalled. This causes the node to have some peers who are inactive and won't send any block announcements. These nodes are removed if the local node is able to receive at least one block announcement from one of its peers as the inactivity of the substream is detected when a notification is sent. If the node won't send or receive any block annoucements for 30 seconds, it's considered stalled and it will evict all peers, causing `ProtocolController` to accept and establish connections from new peers.
altonen
added
A0-please_review
dmitry-markin
approved these changes
Jul 24, 2023
Co-authored-by: Dmitry Markin <dmitry@markin.tech>
kpp
suggested changes
Jul 24, 2023
|
@kpp please take a look |
kpp
approved these changes
Jul 26, 2023
|
bot rebase |
|
Rebased |
bkchr
approved these changes
Aug 15, 2023
Ank4n
pushed a commit
that referenced
this pull request
Aug 20, 2023
* Make peer evictions less aggressive The original implementation of peer eviction prioritized aliveness over connection stability which made the peer count unstable for some users. As this may cause discomfort or infrastructure alerts if stability is tracked, adjust the eviction to be less aggressive by only evicting peers when the node has fully stalled. This causes the node to have some peers who are inactive and won't send any block announcements. These nodes are removed if the local node is able to receive at least one block announcement from one of its peers as the inactivity of the substream is detected when a notification is sent. If the node won't send or receive any block annoucements for 30 seconds, it's considered stalled and it will evict all peers, causing `ProtocolController` to accept and establish connections from new peers. * Update client/network/sync/src/engine.rs Co-authored-by: Dmitry Markin <dmitry@markin.tech> * Track last send and received notification simultaneously --------- Co-authored-by: Dmitry Markin <dmitry@markin.tech> Co-authored-by: parity-processbot <>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation of peer eviction prioritized aliveness over connection stability which made the peer count unstable for some users.
As this may cause discomfort or infrastructure alerts if stability is tracked, adjust the eviction to be less aggressive by only evicting peers when the node has fully stalled. This causes the node to have some peers who are inactive and won't send any block announcements. These nodes are removed if the local node is able to receive at least one block announcement from one of its peers as the inactivity of the substream is detected when a notification is sent.
If the node won't send or receive any block annoucements for 30 seconds, it's considered stalled and it will evict all peers, causing
ProtocolControllerto accept and establish connections from new peers.