Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove peerset debug output test #2267

Merged
merged 3 commits into from
Apr 15, 2019
Merged

Remove peerset debug output test #2267

merged 3 commits into from
Apr 15, 2019

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Apr 12, 2019

This test failed, I assume that the latest nightly changed the format of the debug output. I think we should not test this debug output, as there is no real value in it. Correct me if I'm wrong.

We should not test debug output, especially when it can change.
@bkchr bkchr added the A0-please_review Pull request needs code review. label Apr 12, 2019
@bkchr bkchr requested a review from debris April 12, 2019 13:22
@kianenigma
Copy link
Contributor

Confirm that it is failing, the values are the same, and the test should probably be reformatted to compare the actual values.

@kianenigma
Copy link
Contributor

Though, I would probably either change the test or at least mark it as ignore so that the original author would fix it later.

@bkchr
Copy link
Member Author

bkchr commented Apr 13, 2019

I requested review of the original author and as I have written in the pr description, I don't see any reason for testing the debug output. I don't see any value in testing the debug output of a struct.

@bkchr
Copy link
Member Author

bkchr commented Apr 15, 2019

@kianenigma could you maybe review this one?

@kianenigma
Copy link
Contributor

kianenigma commented Apr 15, 2019

What I meant earlier was if the content of the struct should be checked or not. I have no clue what the content of the struct was and why it was being tested in the first place, if you or @debris are in peace with it then this is good to go. Approve already granted since changes are minimal and in favor of speed (piling PRs everywhere).

@kianenigma kianenigma self-requested a review April 15, 2019 13:41
@bkchr bkchr merged commit 0d96983 into master Apr 15, 2019
@bkchr bkchr deleted the bkchr-fix-test branch April 15, 2019 13:47
@bkchr bkchr restored the bkchr-fix-test branch April 17, 2019 12:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants