Serialisable genesis config #229

arkpar · 2018-06-21T18:28:47Z

Chain spec now contains bootnodes and genesis sections. Genesis can be either raw storage, or serialised GenesisConfig.

gavofyork · 2018-06-21T18:32:09Z

polkadot/cli/src/lib.rs

 		.unwrap_or_else(|f| (Box::new(move || 
 			read_storage_json(&f)
 				.map(|s| { info!("{} storage items read from {}", s.len(), f); s })
 				.unwrap_or_else(|| panic!("Bad genesis state file: {}", f))
 		), vec![]));

-	if matches.is_present("build-genesis") {


can it still output the raw genesis? this is crucial.

added this as polkatod build-spec --raw

gavofyork · 2018-06-22T16:34:01Z

OK - so the idea is that it can be used in two main ways:

You can use whatever the current runtime is (via the confusingly named GenesisConfig) as well as a runtime-dependent JSON Genesis Config file to build a runtime-independent JSON Raw Genesis Map. The Genesis Config file should state what runtime ID/version it is for to avoid later runtimes accidentally being configured with earlier files. The output data file (Raw Genesis Map) actually includes the WASM runtime as well as the initial values it requires to get to validate block 1 and beyond. If the Genesis Config includes bootnode descriptions, then the Raw Genesis Map should also include the same boot nodes (can just be an extra key "_bootnodes").
You can take the Raw Genesis Map (as above) and use it to configure and sync to a blockchain. This includes using it as a file passed on the CLI and as a file embedded into the executable and exposed as a predefined network. All non-local network definitions (i.e. everything except dev and local) should be defined in this way (currently poc-2 is defined via GenesisConfig, which is wrong).

A third, less important use case is:

You can use whatever the current runtime is (via the confusingly named GenesisConfig) as well as a JSON Genesis Config file to configure and sync to a blockchain.

gavofyork · 2018-06-22T16:34:25Z

Is the above what this PR achieves?

arkpar · 2018-06-24T06:43:03Z

@gavofyork Yes, all three scenarios are supported with the following notes:

There is no runtime version information in the runtime-dependent JSON. It will just fail to parse if it does not match the native runtime.
poc-2 config is still defined in the code. Putting it into JSON would require some way to automatically update it with the lates runtime code on the CI. I'll leave it to the next PR.

gavofyork · 2018-06-24T12:57:15Z

Yeah we should probably just rename it to staging and keep it as-is. When we finalise poc-2 then we can export staging and define poc-2 as the runtime-independent file.

gavofyork

Would be good to have local, dev and poc-2 (aka staging) just be JSON files.

gavofyork · 2018-06-25T17:46:30Z

polkadot/cli/src/lib.rs

-	info!("Chain specification: {}", chain_spec);
-
-	config.chain_name = chain_spec.clone().into();
+	let spec = load_spec(&matches);


This is expensive, isn't it? If it loads a potentially huge raw genesis map or genesis config and builds genesis from it, then it's needless most of the time. Stuff should only be loaded if genesis block is needed to be built as it was before.

Before it was loaded unconditionally as well, wasn't? genesis_storage is required in config currently. I'll add an issue to optimise this later, as it requires partial json parsing.

no - genesis_storage was a function that only bothered doing the work if the genesis needed to be computed.

would prefer to have the load-on-demand not phased-out in this pr, but if it's really going to add significant complexity, then i guess it could wait for a second pr.

Implemented

gavofyork

Code looks good. Couple of minor nits.

gavofyork · 2018-07-02T09:39:51Z

polkadot/cli/src/chain_spec.rs

+			ChainSpec::LocalTestnet => service::ChainSpec::local_testnet_config(),
+			ChainSpec::PoC2Testnet => service::ChainSpec::poc_2_testnet_config(),
+			ChainSpec::Custom(f) => {
+					service::ChainSpec::from_json_file(PathBuf::from(f))?


superfluous (and incorrectly indented) code block

gavofyork · 2018-07-02T10:17:49Z

polkadot/service/src/config.rs

-	fn default() -> Configuration {
-		Configuration {
+impl Configuration {
+	/// Create default condif for given chain spec.


* Support Indices * Support Indices in staking module * Update substrate * Format code * Make 2s gossip * Merge develop

* update orml to newest version * add wasmtime support

Fix the incorrect SubspaceApi version

arkpar added 3 commits June 21, 2018 20:11

Genesis serialization

a8cf558

Custom type for AuthorityId

8edb5cd

Merge w master

561bff2

arkpar added the A0-please_review Pull request needs code review. label Jun 21, 2018

gavofyork reviewed Jun 21, 2018

View reviewed changes

Fixed a few minor issues

01160e6

gavofyork reviewed Jun 25, 2018

View reviewed changes

arkpar added 3 commits June 27, 2018 14:08

Merge branch 'master' of github.com:paritytech/polkadot into gen-file

193d746

Fixed unmerged file

5c64dbb

Renamed tag

9875ce3

gavofyork added A5-grumble and removed A0-please_review Pull request needs code review. labels Jun 28, 2018

arkpar added 3 commits June 30, 2018 13:37

Merge branch 'master' of github.com:paritytech/polkadot into gen-file

1ae9128

Deferred genesis loading

d14a70e

Upated wasm runtime

76fb3d9

arkpar added A0-please_review Pull request needs code review. and removed A5-grumble labels Jul 2, 2018

arkpar mentioned this pull request Jul 2, 2018

Block import and export #272

Merged

gavofyork approved these changes Jul 2, 2018

View reviewed changes

gavofyork added A6-mustntgrumble and removed A0-please_review Pull request needs code review. labels Jul 2, 2018

Minor issues

378031a

arkpar added A0-please_review Pull request needs code review. and removed A6-mustntgrumble labels Jul 2, 2018

gavofyork added A8-looksgood and removed A0-please_review Pull request needs code review. labels Jul 3, 2018

gavofyork merged commit 106c112 into master Jul 3, 2018

gavofyork deleted the gen-file branch July 3, 2018 13:56

JoshOrndorff added a commit to moonbeam-foundation/substrate that referenced this pull request Apr 21, 2021

Filter Authors at each block height (paritytech#229)

69476e0

liuchengxu pushed a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021

Feature/update substrate (paritytech#229)

484f408

* Support Indices * Support Indices in staking module * Update substrate * Format code * Make 2s gossip * Merge develop

liuchengxu pushed a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021

Feature/wasmtime (paritytech#229)

7c9878e

* update orml to newest version * add wasmtime support

liuchengxu pushed a commit to autonomys/substrate that referenced this pull request Jun 3, 2022

Merge pull request paritytech#229 from subspace/fix-SubspaceApi-version

9afc249

Fix the incorrect SubspaceApi version

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Serialisable genesis config #229

Serialisable genesis config #229

arkpar commented Jun 21, 2018

gavofyork Jun 21, 2018

arkpar Jun 21, 2018

gavofyork commented Jun 22, 2018 •

edited

Loading

gavofyork commented Jun 22, 2018

arkpar commented Jun 24, 2018 •

edited

Loading

gavofyork commented Jun 24, 2018 •

edited

Loading

gavofyork left a comment

gavofyork Jun 25, 2018

arkpar Jun 27, 2018

gavofyork Jun 28, 2018

gavofyork Jun 28, 2018 •

edited

Loading

arkpar Jul 2, 2018

gavofyork left a comment

gavofyork Jul 2, 2018

gavofyork Jul 2, 2018

Serialisable genesis config #229

Serialisable genesis config #229

Conversation

arkpar commented Jun 21, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gavofyork commented Jun 22, 2018 • edited Loading

gavofyork commented Jun 22, 2018

arkpar commented Jun 24, 2018 • edited Loading

gavofyork commented Jun 24, 2018 • edited Loading

gavofyork left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gavofyork Jun 28, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gavofyork left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gavofyork commented Jun 22, 2018 •

edited

Loading

arkpar commented Jun 24, 2018 •

edited

Loading

gavofyork commented Jun 24, 2018 •

edited

Loading

gavofyork Jun 28, 2018 •

edited

Loading