This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Verify signature and session index during apply phase of im-online. #3418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
approved these changes
Aug 16, 2019
andresilva
approved these changes
Aug 16, 2019
|
Bump |
andresilva
added
A8-looksgood
and removed
A0-please_review
|
I've added a bunch of additional docs to |
gavofyork
approved these changes
Aug 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3091
We can't rely on checks done in
validate_unsigned, since they are only done for the transaction pool and during regular execution (i.e.apply_extrinsic) we really need to perform them again, to prevent a malicious actor creating a block with such invalid extrinsic.Since the testing boilerplate for
im-onlineis non-existent inmasterI'll add a test for this after #3322 is merged.