This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Make light client backend only work with locally available data #3538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
A3-needsresolving
and removed
A0-please_review
svyatonik
added
A0-please_review
gavofyork
added
A3-needsresolving
and removed
A0-please_review
svyatonik
added
A0-please_review
|
Just to be clear: this PR breaks transaction pool on light client => there'll be a follow-up PR that should fix submitting transactions using light client. But probably better not to mix everything in a single PR, just because there going to be more fix-light-client PRs anyway:
|
gavofyork
approved these changes
Sep 12, 2019
Demi-Marie
pushed a commit
to Demi-Marie/substrate
that referenced
this pull request
Sep 17, 2019
…tytech#3538) * removing fetcher dependency from light backend * fix compilation
en
pushed a commit
to en/substrate
that referenced
this pull request
Sep 24, 2019
…tytech#3538) * removing fetcher dependency from light backend * fix compilation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quote from #3480 (see description for details):
So the general idea is to:
Clientbackend to work only with local database && fail withNotAvailableOnLightClientif it requires some data from remote node. Initially I thought about slightly different approach (which is implemented now), whereClientitself would fallback to fetch-from-remote if anything isn't available locally. But this won't work from within executor threads. This will be fixed in follow-up PRs - it is going to be a quite large change, though mostly removing lines/code dependencies, etc