Wookong hardware wallet support #3777

gavofyork · 2019-10-07T16:47:29Z

Rework (mostly a rewrite) of #3667.

into wookong-dot-cht-hd-signer

gavofyork · 2019-10-09T09:07:45Z

@chesterliliang i'm having trouble getting this to work on linux. are there specific drivers needed? here's the output:

gav@pop-os:~/Core/substrate$ sudo ./target/release/subkey --wookong inspect
[sudo] password for gav: 
U��1---------init--g_dev=0------
                                ----------!multi part!------------
                                                                  ----------!multi part!------------
                                                                                                    ----------!multi part!------------
              ----------!multi part!------------
                                                ----------!multi part!------------
                                                                                  ----------!multi part!------------
                                                                                                                    Public Key URI `` is account:
                           Network ID/version: substrate
                                                          Public key (hex): 0x0000000000000000000000000000000000000000000000000000000000000000
                        Address (SS58): 5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM

note that it leave the terminal in a broken state after running, too.

chesterliliang · 2019-10-09T09:17:21Z

@gavofyork Linux should have CP2102 driver. The port could be listed by 'mesg | grep ttyS*'
Here is the C code to init uart in solo crate

int uart_init(int *dev)
{
    int fd; 
#ifdef __linux__git
    fd = open("/dev/ttyUSB0", O_RDWR | O_NOCTTY | O_NONBLOCK); 
#elif TARGET_OS_MAC
    fd = open("/dev/tty.SLAB_USBtoUART", O_RDWR | O_NOCTTY | O_NONBLOCK); 
#else
#   //error "Unsupport platform for uart"
#endif

I will try to figure out why.

gavofyork · 2019-10-09T09:21:17Z

it looks a bit like it's opening & writing to the standard i/o instead of the UART.

gavofyork · 2019-10-09T09:21:34Z

gav@pop-os:~/Core/substrate/scripts$ mesg | grep ttyS*
gav@pop-os:~/Core/substrate/scripts$

chesterliliang · 2019-10-09T09:25:10Z

Device not in the list.. well, do you use ubuntu 18.x? And just for a remind, plz plug the usb connector to the blue board. I put it into another one sometimes..

gavofyork · 2019-10-09T09:26:14Z

ubuntu 19.04

chesterliliang · 2019-10-09T09:33:59Z

Here is a reference to see if the device works on linux:
https://www.silabs.com/community/interface/knowledge-base.entry.html/2018/07/31/how_to_check_if_the-5tUc
and try to install the driver may help:
https://www.silabs.com/products/development-tools/software/usb-to-uart-bridge-vcp-drivers

The product will switch to USB-HID finally, so it will not need driver for every platform. I thought UART is simple enough for early use but it seems it's not ture. T_T

chesterliliang · 2019-10-10T03:23:04Z

@gavofyork is your 19.04 the desktop or server version?

gavofyork · 2019-10-10T12:18:01Z

desktop; i'm back to working on macos and it's ok again

gavofyork · 2019-10-10T12:19:37Z

subkey/subhd/src/lib.rs

+impl Wallet for Wookong {
+	type Pair = sr25519::Pair;
+	fn derive_public(&self, _path: &[DeriveJunction]) -> Result<Public> {
+		// TODO: pass through _path and _password to mutate the key on the device accordingly.


@chesterliliang this needs implementing

Okay. I am on it. But for the password.. the hardware wallet always has one password for all accounts and the device will keep the password for verify. Device api functions like

fn verify_password(password); fn change_password(old, new);

could be provided. And we could call verify function here. But the derive will not depend on password as salt but just the path. Is that OK?

yeah - sorry the _password is old and doesn't need to be implemented at all.

gavofyork · 2019-10-10T12:19:40Z

subkey/subhd/src/lib.rs

+		}
+	}
+	fn sign(&self, _path: &[DeriveJunction], message: &[u8]) -> Result<Signature> {
+		// TODO: pass through _path and _password to mutate the key on the device accordingly.


@chesterliliang this needs implementing

Should we verify password as well when do the sign?

no - can ignore _password - it's part of an old design and not relevant any more.

gavofyork · 2019-10-10T12:21:06Z

subkey/subhd/src/lib.rs

+}
+
+/// Unit type representing the Wookong hardware wallet.
+pub struct Wookong;


@chesterliliang if the device can be made to support multiple root keys (which would be nice, i think) then this could be changed thus:

pub struct Wookong { account: sr25519::Public, } impl Wookong { fn with_account(account: sr25519::Public) -> Self { Wookong { account } } }

the Wallet functions for it would then feed self.account through to the hardware to ensure it operated on the right account.

If they are root keys(seed? before derive), we could find them by index, it seems hardware can not know which one is the right by account.

hmm, then they can be enumerated which isn't so great for privacy.

couldn't it just store the public keys along with the roots and cycle through those that it know until it either finds the correct one or returns some KeyNotFound error?

It's possible but must under the same derive path or same rule to manage the path. Seems not a big trouble. Will try to give an implementation for further discussion.

burdges · 2019-10-12T14:31:05Z

Just fyi @chesterliliang we'll eventually "repair" the missuse of i and the chain code by SURI. See w3f/schnorrkel#45 and #3396 We'll play some tricks to keep all current derivations the same, which requires a coordinated upgrade of both subkey and schnorrkel, but I wanted to warn you. :)

chesterliliang · 2019-10-12T15:11:53Z

@burdges Thanks Jeff. Don't worry about us since we just start to work on derive part. Could you plz provide one, just one test vector if the issue is fixed?

burdges · 2019-10-12T16:03:12Z

We'll avoid currently allowable test vectors changing. Yet, subkey will continue to not use chaincodes for the questionable purpose for which bip32 added them, so maybe some future wallets will use it in incompatible ways. I'm just warning about this future interface change on schnorrkel

gnunicorn · 2020-02-18T14:22:51Z

is this still being worked on?

chesterliliang · 2020-02-18T15:54:32Z

No... Team has financial problem.. plz close it...

chesterliliang and others added 5 commits September 23, 2019 11:34

fix mac

fdc6f1c

remove unknown error

2d4c315

make driver into crate, fix space

e40d01e

Merge branch 'cht-hd-signer' of https://github.com/wookong-dot/substrate

ef66509

into wookong-dot-cht-hd-signer

Rework and refactor. CLI now part of original interface.

38ef2f7

gavofyork added the A3-in_progress Pull request is in progress. No review needed at this stage. label Oct 8, 2019

gavofyork mentioned this pull request Oct 8, 2019

Add hardware sr25519 signer to subkey #3667

Closed

gavofyork added 2 commits October 8, 2019 16:31

Fix up the build.

116cd8e

Minor improvements

1ed88fb

Minor fix

dfa6f79

gavofyork commented Oct 10, 2019

View reviewed changes

gnunicorn closed this Feb 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wookong hardware wallet support #3777

Wookong hardware wallet support #3777

gavofyork commented Oct 7, 2019

gavofyork commented Oct 9, 2019

chesterliliang commented Oct 9, 2019

gavofyork commented Oct 9, 2019

gavofyork commented Oct 9, 2019

chesterliliang commented Oct 9, 2019

gavofyork commented Oct 9, 2019

chesterliliang commented Oct 9, 2019

chesterliliang commented Oct 10, 2019

gavofyork commented Oct 10, 2019

gavofyork Oct 10, 2019

chesterliliang Oct 10, 2019

gavofyork Oct 11, 2019

gavofyork Oct 10, 2019

chesterliliang Oct 10, 2019

gavofyork Oct 11, 2019

gavofyork Oct 10, 2019 •

edited

Loading

chesterliliang Oct 10, 2019

gavofyork Oct 11, 2019 •

edited

Loading

chesterliliang Oct 12, 2019

burdges commented Oct 12, 2019

chesterliliang commented Oct 12, 2019

burdges commented Oct 12, 2019 •

edited

Loading

gnunicorn commented Feb 18, 2020

chesterliliang commented Feb 18, 2020

Wookong hardware wallet support #3777

Wookong hardware wallet support #3777

Conversation

gavofyork commented Oct 7, 2019

gavofyork commented Oct 9, 2019

chesterliliang commented Oct 9, 2019

gavofyork commented Oct 9, 2019

gavofyork commented Oct 9, 2019

chesterliliang commented Oct 9, 2019

gavofyork commented Oct 9, 2019

chesterliliang commented Oct 9, 2019

chesterliliang commented Oct 10, 2019

gavofyork commented Oct 10, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gavofyork Oct 10, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gavofyork Oct 11, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

burdges commented Oct 12, 2019

chesterliliang commented Oct 12, 2019

burdges commented Oct 12, 2019 • edited Loading

gnunicorn commented Feb 18, 2020

chesterliliang commented Feb 18, 2020

gavofyork Oct 10, 2019 •

edited

Loading

gavofyork Oct 11, 2019 •

edited

Loading

burdges commented Oct 12, 2019 •

edited

Loading