-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Conversation
Here's the resulting time for
This seems pretty fast, so maybe the problems only occur under certain conditions? |
@Stefie maybe you could run these benchmarks on your machine? |
this does benchmark put_code in native. I don't remember precisely but thoughts wasm was used always for block production. maybe in wasm the put_code performance are very different 🤔 ? |
Oh, good point! What would be the best way to benchmark in wasm then? |
I don't know @pepyakin ? |
@expenses you can setup a wasm blob like this one: https://github.com/paritytech/substrate/tree/master/primitives/runtime-interface/test-wasm Expose a function |
Sorry, I was out of office yesterday. If you tell me how, I'm happy to do that! I never ran any benchmarking tests for Substrate. The times I mentioned in #3885 were with the |
@bkchr is this even possible, given that |
@expenses please look at the linked code, you create the storage etc from std and just call into wasm to execute the benchmark method. |
Closing due to solutions having arised. |
#3885 and #3819 note that
put_code
can take too long on large wasm files, and cause block production to fail. This PR adds benchmarks for this using compiled ink examples.