Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update libp2p again #445

Merged
merged 1 commit into from
Jul 29, 2018
Merged

Update libp2p again #445

merged 1 commit into from
Jul 29, 2018

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Jul 28, 2018

Right now it happens that the buffer of mplex becomes full because the remote just sends us tons of packets at once. If that happens, additional packets (like, packets of data) are simply ignored.

This fixes it by increasing the buffer size (the value is now high enough that it is never reached) and killing all the substreams of the connection if we happen to reach the limit.

@tomaka tomaka added the A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). label Jul 28, 2018
@tomaka
Copy link
Contributor Author

tomaka commented Jul 28, 2018

The underlying cause is that mplex is a very basic protocol with no backpressure mechanism. It should eventually be replaced with Yamux or QUIC.

@arkpar arkpar merged commit a118a85 into paritytech:master Jul 29, 2018
@tomaka tomaka deleted the update-libp2p branch July 29, 2018 08:37
dvdplm added a commit that referenced this pull request Jul 30, 2018
* master: (86 commits)
  Make contract a separate runtime module (#345)
  Version bump (#450)
  DB-based blockchain data cache for light nodes (#251)
  Update libp2p again (#445)
  Update version on git head change (#444)
  Fix the public key of bootnode 3 (#441)
  Update libp2p (#442)
  Switch to the master branch of libp2p (#427)
  Export ws port 9944 and add doc (#440)
  Iterate over overlay to decide which keys to purge (#436)
  Exit signal gets its own trait (#433)
  Add docker image (#375)
  Reset peers.json if the content is not loadable (#405)
  Limit number of incoming connections (#391)
  Fix memory leaks in libp2p (#432)
  Do not queue empty blocks set for import (#431)
  5 random fixes (#1) (#435)
  Chore: fix typo (#434)
  Prevent building invalid blocks (#430)
  Better logging for public key mismatch (#429)
  ...
lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants