Adds a test to ensure that we clear the heap between calls into runtime #4903
Conversation
The tests shows that we currently not clearing the heap in wasmtime. For now we don't run the test for wasmtime.
bkchr
added
A0-please_review
| @@ -34,4 +34,7 @@ pub trait WasmRuntime { | |||
|
|
|||
| /// Call a method in the Substrate runtime by name. Returns the encoded result on success. | |||
| fn call(&mut self, method: &str, data: &[u8]) -> Result<Vec<u8>, Error>; | |||
|
|
|||
| /// Get the value from a global with the given `name`. | |||
| fn get_global_val(&mut self, name: &str) -> Result<Option<Value>, Error>; | |||
There was a problem hiding this comment.
We tend not use get_ prefix. Rename it to global_val perhaps?
|
Is this really intended behaviour? I'd expect runtime instance to keep all of its state between calls. This might not be what we want in substrate, but it makes more sense for wasmi in general. It would make more sense to have an explicit |
Yes that is intended behavior, we clear the memory between calls. |
…me (paritytech#4903) * Adds a test to ensure that we clear the heap between calls into runtime The tests shows that we currently not clearing the heap in wasmtime. For now we don't run the test for wasmtime. * Fix compilation
The tests shows that we currently not clearing the heap in wasmtime.
For now we don't run the test for wasmtime.