This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
u32 Refcounts, plus migration #7164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
A0-please_review
shawntabrizi
approved these changes
Sep 21, 2020
|
This would make for a good candidate to try out a different migration process where we extract the migration. |
kianenigma
approved these changes
Sep 22, 2020
10 tasks
|
bot merge |
|
Trying merge. |
ghost
merged commit
LaurentTrk
added a commit
to LaurentTrk/go-substrate-rpc-client
that referenced
this pull request
Oct 5, 2020
mikiquantum
pushed a commit
to centrifuge/go-substrate-rpc-client
that referenced
this pull request
Oct 6, 2020
* Add metadata V12 * FIX AccountInfo Refcount should be unsigned 32 (see paritytech/substrate#7164) * FIX Use Module index when looking for Call index * FIX Use released v2.0.0 substrate version * FIX Goimports types/metadataV12.go * FIX Add some unit tests * Remove run-substrate-docker v1 makefile target. Co-authored-by: Laurent Turek <laurent.turek@gmail.com>
|
It was fun seeing billions of USD on my balance in Fearless Wallet :D |
s3krit
added
D1-audited 👍
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is quite conceivable that runtimes will need more than 256 reference locks on accounts, especially with multi-asset pallets.
This switches the count type to
u32.A migration is needed.