Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Rename TRANSACTION_VERSION to EXTRINSIC_VERSION #7258

Merged
merged 1 commit into from
Oct 4, 2020

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Oct 4, 2020

This renames the constant TRANSACTION_VERSION to EXTRINSIC_VERSION
to reflect the real usage.

Fixes: #7255

This renames the constant `TRANSACTION_VERSION` to `EXTRINSIC_VERSION`
to reflect the real usage.
@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Oct 4, 2020
@bkchr bkchr requested a review from jacogr October 4, 2020 07:44
@bkchr
Copy link
Member Author

bkchr commented Oct 4, 2020

bot merge

@ghost
Copy link

ghost commented Oct 4, 2020

Waiting for commit status.

@ghost
Copy link

ghost commented Oct 4, 2020

Checks failed; merge aborted.

@bkchr bkchr merged commit 6bcc385 into master Oct 4, 2020
@bkchr bkchr deleted the bkchr-unchecked-extrinsic-version-rename branch October 4, 2020 12:34
liuchengxu pushed a commit to liuchengxu/substrate that referenced this pull request Oct 5, 2020
This renames the constant `TRANSACTION_VERSION` to `EXTRINSIC_VERSION`
to reflect the real usage.
ordian added a commit that referenced this pull request Oct 9, 2020
…up-updates

* master:
  Async keystore + Authority-Discovery async/await (#7000)
  Fixes logging of target names with dashes (#7281)
  seal: Add automated weights for contract API calls (#7017)
  add ss58 id for nodle (#7279)
  Refactor CurrencyToVote (#6896)
  bump-allocator: document & poison (#7277)
  Reset flaming fir network (#7274)
  reschedule (#6860)
  Drop system cache for trie benchmarks (#7242)
  client: improve log formatting (#7272)
  Rework `InspectState` (#7271)
  SystemOrigin trait (#7226)
  Update ss58 registry for Dock network (#7263)
  .maintain/monitoring: Add alert when continuous task ends (#7250)
  Rename `TRANSACTION_VERSION` to `EXTRINSIC_VERSION` (#7258)
  Split block announce processing into two parts (#6958)
  Fix offchain election to respect the weight (#7215)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Naming conflict two transaction versions with different values.
2 participants