Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

update jsonrpsee to remove allow(dead_code) #8302

Merged
1 commit merged into from
Mar 9, 2021
Merged

update jsonrpsee to remove allow(dead_code) #8302

1 commit merged into from
Mar 9, 2021

Conversation

niklasad1
Copy link
Member

No description provided.

@niklasad1 niklasad1 added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Mar 9, 2021
@niklasad1 niklasad1 requested a review from kianenigma March 9, 2021 12:26
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Mar 9, 2021
@niklasad1 niklasad1 added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). and removed A0-please_review Pull request needs code review. labels Mar 9, 2021
kianenigma
kianenigma approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick follow up

@kianenigma
Copy link
Contributor

bot merge

@ghost
Copy link

ghost commented Mar 9, 2021

Checks failed; merge aborted.

@kianenigma
Copy link
Contributor

bot merge force

@ghost
Copy link

ghost commented Mar 9, 2021

Trying merge.

@ghost ghost merged commit a38c948 into master Mar 9, 2021
@ghost ghost deleted the na-remote-ext-update-jsonrpsee branch March 9, 2021 13:42
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

@kianenigma kianenigma kianenigma approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niklasad1 @kianenigma @bkchr