Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Migrate pallet-scheduler to pallet attribute macro #8769

Merged
10 commits merged into from
May 18, 2021
Merged

Migrate pallet-scheduler to pallet attribute macro #8769

10 commits merged into from
May 18, 2021

Conversation

stanly-johnson
Copy link
Contributor

Part of #7882.

Converts the Scheduler pallet to the new pallet attribute macro introduced in #6877.

Following the upgrade guidelines here: https://crates.parity.io/frame_support/attr.pallet.html#upgrade-guidelines.

⚠️ Breaking Change ⚠️

From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines

storages now use PalletInfo for module_prefix instead of the one given to decl_storage: Thus any use of this pallet in construct_runtime! should be careful to update name in order not to break storage or to upgrade storage (moreover for instantiable pallet). If pallet is published, make sure to warn about this breaking change.

gui1117
gui1117 approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the calls function should stay private, but otherwise it is good to me

Also in general I prefer not to format untouched code, that make review more easy.

Polkadot/Kusama/Westend correctly have Scheduler as pallet name so no migration needed

frame/scheduler/src/lib.rs Outdated Show resolved Hide resolved
frame/scheduler/src/lib.rs Outdated Show resolved Hide resolved
frame/scheduler/src/lib.rs Outdated Show resolved Hide resolved
frame/scheduler/src/lib.rs Outdated Show resolved Hide resolved
frame/scheduler/src/lib.rs Outdated Show resolved Hide resolved
frame/scheduler/src/lib.rs Outdated Show resolved Hide resolved
frame/scheduler/src/lib.rs Outdated Show resolved Hide resolved
frame/scheduler/src/lib.rs Outdated Show resolved Hide resolved
frame/scheduler/src/lib.rs Outdated Show resolved Hide resolved
frame/scheduler/src/lib.rs Outdated Show resolved Hide resolved
@gui1117 gui1117 added A0-please_review Pull request needs code review. B3-apinoteworthy C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 12, 2021
@stanly-johnson
Copy link
Contributor Author

Sorry about the unwanted formatting, I ran cargo fmt and didn't notice the unrelated changes. Reverted most of it

KiChjang
KiChjang suggested changes May 15, 2021
View reviewed changes
Copy link
Contributor

@KiChjang KiChjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The metadata for events needs to be added, others are documentation and whitespace changes.

frame/scheduler/src/lib.rs Show resolved Hide resolved
frame/scheduler/src/lib.rs Show resolved Hide resolved
frame/scheduler/src/lib.rs Outdated Show resolved Hide resolved
frame/scheduler/src/lib.rs Show resolved Hide resolved
frame/scheduler/src/lib.rs Outdated Show resolved Hide resolved
frame/scheduler/src/lib.rs Outdated Show resolved Hide resolved
stanly-johnson and others added 5 commits May 15, 2021 10:16
@stanly-johnson @KiChjang
Update frame/scheduler/src/lib.rs
79d6bfb 
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
@stanly-johnson @KiChjang
Update frame/scheduler/src/lib.rs
447b062 
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
@stanly-johnson @KiChjang
Update frame/scheduler/src/lib.rs
1977348 
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
@stanly-johnson @KiChjang
Update frame/scheduler/src/lib.rs
62517dc 
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
@stanly-johnson @KiChjang
Update frame/scheduler/src/lib.rs
f77e344 
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
@KiChjang
Copy link
Contributor

bot merge

@ghost
Copy link

ghost commented May 18, 2021

Trying merge.

@ghost ghost merged commit dcd8463 into paritytech:master May 18, 2021
@stanly-johnson stanly-johnson deleted the stanly-migrate-pallet-scheduler branch May 18, 2021 10:49
@AurevoirXavier AurevoirXavier mentioned this pull request Aug 3, 2021
Merged
11 tasks
nazar-pc pushed a commit to autonomys/substrate that referenced this pull request Aug 8, 2021
@stanly-johnson @KiChjang @nazar-pc
Migrate pallet-scheduler to pallet attribute macro (paritytech#8769)
57ee8e0 
* migrate to pallet!

* fixes

* fix genesis

* code review fixes

* Update frame/scheduler/src/lib.rs

Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>

* Update frame/scheduler/src/lib.rs

Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>

* Update frame/scheduler/src/lib.rs

Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>

* Update frame/scheduler/src/lib.rs

Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>

* Update frame/scheduler/src/lib.rs

Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>

* fix metadata

Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gui1117 gui1117 gui1117 approved these changes

@KiChjang KiChjang KiChjang approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stanly-johnson @KiChjang @gui1117