Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove native execution, grow heap as needed #8893

Closed
wants to merge 9 commits into from

Conversation

gavofyork
Copy link
Member

@gavofyork gavofyork commented May 24, 2021

This does two things:

  • Removes non-encoded native execution;
  • Grows the heap as needed up to some (very large) maximum as it runs out of memory.

This essentially avoids the memory requirement issue by assuming that runtimes are probably not going to try to run the node out of memory (a pre-existing assumption of native execution mode, so no worse than at present).

It may be reasonable to constrain the heap pages to a different maximum (i.e. not 3 GB) in the case of running untrusted (i.e. PVF) code.

It removes the direct native call execution. It currently keeps the indirect (encoded/decoded) native call execution.

TODO:

  • Remove encoded native execution
  • Different heap pages for PVF

Closes #7288

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label May 24, 2021
@gavofyork gavofyork added A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C7-high ❗️ D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. and removed A0-please_review Pull request needs code review. labels May 24, 2021
@gavofyork gavofyork changed the title Grow heap to a maximum if needed Remove native execution, grow heap as needed May 24, 2021
@xlc
Copy link
Contributor

xlc commented May 25, 2021

This closes #7288?

@gavofyork gavofyork requested a review from andresilva as a code owner May 28, 2021 15:20
@stale
Copy link

stale bot commented Jul 7, 2021

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Jul 7, 2021
@stale stale bot closed this Jul 21, 2021
@louismerlin louismerlin removed the D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. label Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A3-in_progress Pull request is in progress. No review needed at this stage. A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. B0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation and Removal of Substrate Native Runtime Optimization
6 participants