Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove dependency on substrate-prometheus-endpoint that is no longer required #9521

Merged
merged 2 commits into from
Aug 11, 2021
Merged

Remove dependency on substrate-prometheus-endpoint that is no longer required #9521

merged 2 commits into from
Aug 11, 2021

Conversation

chevdor
Copy link
Contributor

@chevdor chevdor commented Aug 9, 2021 •
edited
Loading

This PR follows #9319 and removes a dependency that is no longer required.

@chevdor chevdor added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Aug 9, 2021
@chevdor chevdor requested review from gilescope and bkchr August 9, 2021 10:43
@chevdor chevdor marked this pull request as ready for review August 9, 2021 10:43
@chevdor chevdor added the A0-please_review Pull request needs code review. label Aug 9, 2021
@chevdor chevdor force-pushed the wk-sc-transaction-pool-api-prometheus-feature branch from 9c84bd9 to 1d7c9c5 Compare August 9, 2021 10:47
bkchr
bkchr suggested changes Aug 9, 2021
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

futures_timer
sp_utils
sp_trie
sp_api
parking_lot
serde
wasm_timer

Also do not seem to be used.

@bkchr
Copy link
Member

bkchr commented Aug 9, 2021

Have you run any cargo update? Can you please revert this. You have updated deps like rocksb.

@chevdor chevdor force-pushed the wk-sc-transaction-pool-api-prometheus-feature branch from 951f573 to e2ac9a5 Compare August 9, 2021 14:33
@chevdor chevdor force-pushed the wk-sc-transaction-pool-api-prometheus-feature branch from e2ac9a5 to 7b1ccd8 Compare August 9, 2021 14:35
gilescope
gilescope approved these changes Aug 10, 2021
View reviewed changes
Copy link
Contributor

@gilescope gilescope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@gilescope
Copy link
Contributor

(FYI: the contribution guidelines suggest not to use force-push)

@bkchr bkchr merged commit 86783fe into master Aug 11, 2021
@bkchr bkchr deleted the wk-sc-transaction-pool-api-prometheus-feature branch August 11, 2021 09:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

@gilescope gilescope gilescope approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chevdor @bkchr @gilescope