sp-utils => sc-utils

[gilescope]

It's not referenced by anything in primitives so shouldn't really live there. (Part of #9214 )

[bkchr]

bot merge

[ghost]

Waiting for commit status.

[ghost]

Bot will approve on the behalf of @bkchr, since they are a team lead, in an attempt to reach the minimum approval count

[athei]

This PR broke the CI I think. It is not properly formatted and probably needs a polkadot companion. Curious why the CI in this PR did not catch this.

[joao-paulo-parity]

@athei

It is not properly formatted

cargo-fmt is allowed to fail. According to git blame, it got changed some time ago (maybe it got relaxed due to formatting PRs and no one turned it back on after?). In any case it's very easy to change that, simply set allow_failure: false and it'll become mandatory again.

and probably needs a polkadot companion

packages are patched by name and that might have been the problem, since the dependency got renamed here. I could not intuit yet why it passed here, but not on master, since it should have patched the same way for both scenarios: here the PR does not have a companion, so it doesn't get patched; master is not a PR, thus it does not get patched, either.

[ordian]

It should've returned an error here:

substrate/.maintain/gitlab/check_polkadot_companion_build.sh

Line 96 in d73c37e

cargo update -p sp-core

considering it sets early return:

substrate/.maintain/gitlab/check_polkadot_companion_build.sh

Line 12 in d73c37e

set -e

.

[bkchr]

It should've returned an error here:

substrate/.maintain/gitlab/check_polkadot_companion_build.sh

Line 96 in d73c37e

cargo update -p sp-core

This line is totally stupid and not even required for these checks.

The problem here is that we use patching and patched a non-existing crate, while the old sp-utils was still around (I still pointed to the old version in master).

The check needs to include checks for deleted crates.