Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Use tokio runtime handle instead of TaskExecutor abstraction #9737

Merged
7 commits merged into from
Sep 12, 2021

Commits on Sep 9, 2021

  1. Use tokio runtime handle instead of TaskExecutor abstraction

    Before this pr we had the `TaskExecutor` abstraction which theoretically
    allowed that any futures executor could have been used. However, this
    was never tested and is currently not really required. Anyone running a
    node currently only used tokio and nothing else (because this was hard
    coded in CLI). So, this pr removes the `TaskExecutor` abstraction and
    relies directly on the tokio runtime handle.
    
    Besides this changes, this pr also makes sure that the http and ws rpc
    server use the same tokio runtime. This fixes a panic that occurred when
    you drop the rpc servers inside an async function (tokio doesn't like
    that a tokio runtime is dropped in the async context of another tokio
    runtime).
    
    As we don't use any custom runtime in the http rpc server anymore, this
    pr also removes the `rpc-http-threads` cli argument. If external parties
    complain that there aren't enough threads for the rpc server, we could
    bring support for increasing the thread count of the tokio runtime.
    bkchr committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    01b5a3f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b735028 View commit details
    Browse the repository at this point in the history
  3. FMT

    bkchr committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    a4a7076 View commit details
    Browse the repository at this point in the history
  4. Fix try runtime

    bkchr committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    79a831e View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2021

  1. Configuration menu
    Copy the full SHA
    121841a View commit details
    Browse the repository at this point in the history
  2. Remove warnings

    bkchr committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    a419734 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3a0a555 View commit details
    Browse the repository at this point in the history