Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Small quoting comment fix for heartbeat storage #9927

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Small quoting comment fix for heartbeat storage #9927

merged 1 commit into from
Oct 4, 2021

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Oct 4, 2021

Tiny quotes fix that snuck in lately (something I picked up elsewhere in document generation)

Tiny quotes fix that snuck in lately (something I picked up elsewhere in document generation)
@jacogr jacogr added A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes labels Oct 4, 2021
@bkchr bkchr added D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit C1-low PR touches the given topic and has a low impact on builders. and removed A0-please_review Pull request needs code review. labels Oct 4, 2021
@bkchr
Copy link
Member

bkchr commented Oct 4, 2021

bot merge

@ghost
Copy link

ghost commented Oct 4, 2021

Waiting for commit status.

@ghost
Copy link

ghost commented Oct 4, 2021

Bot will approve on the behalf of @bkchr, since they are a team lead, in an attempt to reach the minimum approval count

@ghost
Copy link

ghost commented Oct 4, 2021

Merge failed: Could not recover from: "Required status check \"continuous-integration/gitlab-check-polkadot-companion-build\" is failing. At least 2 approving reviews are required by reviewers with write access." due to: WithIssue: Error merging: "Required status check \"continuous-integration/gitlab-check-polkadot-companion-build\" is failing."

@bkchr
Copy link
Member

bkchr commented Oct 4, 2021

bot merge

@ghost
Copy link

ghost commented Oct 4, 2021

Trying merge.

@bkchr bkchr merged commit ca90ea7 into master Oct 4, 2021
@bkchr bkchr deleted the jg-patch-1 branch October 4, 2021 11:56
ordian added a commit that referenced this pull request Oct 5, 2021
* master: (125 commits)
  Update multiple dependencies (#9936)
  Speed up timestamp generation when logging (#9933)
  First word should be Substrate not Polkadot (#9935)
  Improved file not found error message (#9931)
  don't read events in elections anymore. (#9898)
  Remove incorrect sanity check (#9924)
  Require crypto scheme for `insert-key` (#9909)
  chore: refresh of the substrate_builder image (#9808)
  Introduce block authorship soft deadline (#9663)
  Rework Transaction Priority calculation (#9834)
  Do not propagate host RUSTFLAGS when checking for WASM toolchain (#9926)
  Small quoting comment fix (#9927)
  add clippy to CI (#9694)
  Ensure BeforeBestBlockBy voting rule accounts for base (#9920)
  rm `.maintain` lock (#9919)
  Downstream `node-template` pull (#9915)
  Implement core::fmt::Debug for BoundedVec (#9914)
  Quickly skip invalid transactions during block authorship. (#9789)
  Add SS58 prefix for Automata (#9805)
  Clean up sc-peerset (#9806)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants