-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented sign_prehashed
for ecdsa::Keypair
and eth::Keypair
#1598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Out of interest, is this something you found yourself wanting?
I'm thinking it's probably worth adding the same to the ecdsa
impl for consistency (internally both sign_prehashed
fns would end up being identical but hey ho)
That is correct - and it's something that is often found in other similar libraries, including ethers |
You could call |
Yup, true! Are you up for adding that also? |
Sure, I'll do it later today |
sign_prehashed
for eth::Keypair
sign_prehashed
for ecdsa::Keypair
and eth::Keypair
Sorry for this mess, I'm having a few issues with rust analyzer. I'll reboot my laptop and try again |
No worries, and thank yoU! Looking good to me now! |
Some people might find this useful 😄
cc @niklasad1 @jsdw thanks ❤️