Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dependencies, bumps substrate to 2.0.1 #219

Merged
merged 7 commits into from
Jan 14, 2021
Merged

Upgrade dependencies, bumps substrate to 2.0.1 #219

merged 7 commits into from
Jan 14, 2021

Conversation

ascjones
Copy link
Contributor

Fixes #218

@ascjones
Copy link
Contributor Author

ascjones commented Jan 12, 2021 •
edited
Loading

Fix for failure in multi-addr, possibly need to wait for release of https://crates.io/crates/sc-network which depends on the old libp2p? libp2p/rust-libp2p@aa2547e.

Also see paritytech/substrate#7877

@h4x3rotab h4x3rotab mentioned this pull request Jan 14, 2021
Merged
@niklasad1
Copy link
Member

niklasad1 commented Jan 14, 2021 •
edited
Loading

Fix for failure in multi-addr, possibly need to wait for release of https://crates.io/crates/sc-network which depends on the old libp2p

It is getting backported libp2p/rust-libp2p#1925

@mxinden
Copy link

mxinden commented Jan 14, 2021

Fix for failure in multi-addr, possibly need to wait for release of https://crates.io/crates/sc-network which depends on the old libp2p

It is getting backported libp2p/rust-libp2p#1925

Backport is released. Please update to parity-multiaddr v0.9.7.

@ascjones
Copy link
Contributor Author

ascjones commented Jan 14, 2021 •
edited
Loading

Patched parity-multiaddr is a transient dependency so it now builds with no change. Thanks @mxinden 🚀

@ascjones ascjones requested a review from niklasad1 January 14, 2021 16:08
niklasad1
niklasad1 reviewed Jan 14, 2021
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
niklasad1
niklasad1 reviewed Jan 14, 2021
View reviewed changes
client/Cargo.toml

[dev-dependencies]
async-std = { version = "1.6.4", features = ["attributes"] }
env_logger = "0.7.1"
async-std = { version = "1.8.0", features = ["attributes"] }
Copy link
Member

@niklasad1 niklasad1 Jan 14, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE, this feature will be leaked into dependencies (it's fine but still.. the new feature resolver is stabilized and will fix this FWIW)

niklasad1
niklasad1 approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, LGTM

@ascjones ascjones merged commit 6175cb7 into master Jan 14, 2021
@niklasad1 niklasad1 deleted the aj-update-substrate branch January 14, 2021 17:11
@ascjones ascjones mentioned this pull request Feb 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update substrate to 2.0.1
3 participants
@ascjones @niklasad1 @mxinden